Repository navigation
feat: add invocation-scoped task lifecycle foundation - #731
Closed
zhongkechen wants to merge 18 commits into
Closed
zhongkechen wants to merge 18 commits into
zhongkechen wants to merge 18 commits into
Conversation
zhongkechen
added this pull request to stack #732
September 24, 2026 23:12
zhongkechen
force-pushed
the
feature/lmi-invocation-scope
branch
2 times, most recently
from
September 25, 2026 22:20
02edc13 to
ebad82c
Compare
zhongkechen
marked this pull request as ready for review
September 25, 2026 22:21
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
September 25, 2026 22:23 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
force-pushed
the
feature/lmi-invocation-scope
branch
from
September 25, 2026 22:58
092a4a2 to
d81fee3
Compare
This comment has been minimized.
This comment has been minimized.
zhongkechen
force-pushed
the
feature/lmi-invocation-scope
branch
from
September 29, 2026 17:14
d81fee3 to
18759d5
Compare
zhongkechen
force-pushed
the
feature/lmi-invocation-scope
branch
from
September 29, 2026 17:39
18759d5 to
fba3f18
Compare
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
September 29, 2026 17:45 — with
GitHub Actions
Failure
zhongkechen
force-pushed
the
feature/lmi-invocation-scope
branch
from
September 29, 2026 17:49
fba3f18 to
73b4b16
Compare
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
September 29, 2026 18:29 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zhongkechen
force-pushed
the
feature/lmi-invocation-scope
branch
from
September 29, 2026 22:12
94b2803 to
bc29489
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Codex AI reviewNo actionable findings in the PR changes. Tests were not executed under the read-only review constraints; runtime concurrency and cloud behavior remain unverified. Reviewed commit |
zhongkechen
removed this pull request from stack #732
October 21, 2026 02:10
Contributor
Author
|
The invocation task registry, admission/cancellation controls, descendant draining and associated tests were incorporated into merged #782, now on main at |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link, if available
Foundation for #726. Stacked on #728 and targeting
test/lmi-cloud-lifecycle; retarget tomainafter that prerequisite lands. Invocation deadlines and bounded cleanup remain in #733; opt-in per-invocation executors remain in #735.Description
Give each invocation an
ExecutionManager-owned task lifecycle that coordinates task submission, operation admission, polling, and checkpoint shutdown. Tasks register before dispatch and track logical completion separately from their interruptible handle and actual exit. The branch incorporates upstream maind64973fc6b1fb2fe69c0bce421e99a4aad417addthrough #728.FutureTaskbefore executor dispatch so a saturatedCallerRunsPolicytask can be interrupted while submission is still on the stack. Atomically select result publication or cancellation: a selected success/failure cannot be overtaken by cancellation, and cancellation-winning workers cannot publish a competing result. Physical cancellation precedes logical cancellation; registry removal precedes the actual exit signal.DRAINING, already-admitted child/map/parallel work can register and run descendants, including delayed nested steps. Root and unrelated new work are rejected. Exact manager ownership prevents cross-invocation leakage on reused or inline executor threads.admissionLock; shutdown waits for admitted enqueue calls before its final flush. An interrupted drain staysDRAININGso subsequent cleanup can persist results from already-admitted work for replay.Testing
Head
3faa40c19f77704b3fe2b3a90b365e61126e47d2has validated treea74e74d7fd1b40f80da78eb05d982363994b7ef4and includes upstream maind64973fc6b1fb2fe69c0bce421e99a4aad417addthrough #728. The runtime patch relative to #728 is unchanged by this synchronization.mvn -B clean spotless:check verifypassed all ten reactor modules, with 3,283 tests passed, 34 conditional/cloud tests skipped, and zero failures/errors.git diff --check, and clean working-tree verification passed.Checklist
test/lmi-cloud-lifecycleBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.