Repository navigation
Fix IMDS region resolution in Local Zones - #10843
Open
AndrewAsseily wants to merge 2 commits into
Open
AndrewAsseily wants to merge 2 commits into
AndrewAsseily wants to merge 2 commits into
Conversation
InstanceMetadataRegionFetcher derived the region by stripping the last character from placement/availability-zone, which breaks for Local Zones (us-east-1-atl-2a became us-east-1-atl-2). Read placement/region instead, which returns the parent region directly. Also fix a typo in scripts/new-change.
The region fetcher now reads placement/region, so the mocked IMDS response is a region rather than an availability zone.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: CLI-2692
Description of changes: InstanceMetadataRegionFetcher derived the region by stripping the last character from placement/availability-zone, which breaks for Local Zones (us-east-1-atl-2a became us-east-1-atl-2). Read placement/region instead, which returns the parent region directly.
Also fix a typo in scripts/new-change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.