Fix ShorthandParseSyntaxError message showing literal placeholder instead of caret#10494
Open
mangodxd wants to merge 1 commit into
Open
Fix ShorthandParseSyntaxError message showing literal placeholder instead of caret#10494mangodxd wants to merge 1 commit into
mangodxd wants to merge 1 commit into
Conversation
…tead of caret
The _construct_msg method was missing an 'f' prefix on the last
string fragment, so '{self._error_location()}' was printed literally
instead of showing the caret pointing at the parse failure position.
Fixes aws#10467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _construct_msg method in ShorthandParseSyntaxError was missing an prefix on the last string fragment, so {self._error_location()} was printed literally instead of showing the caret. This made shorthand parsing errors much harder to diagnose — the carets were the main way to locate the mistake in long expressions.
Also adds a test asserting the message content includes both the input and the caret.