Redact CodeArtifact auth token from command stderr#10367
Open
dfgvaetyj3456356-hash wants to merge 1 commit into
Open
Redact CodeArtifact auth token from command stderr#10367dfgvaetyj3456356-hash wants to merge 1 commit into
dfgvaetyj3456356-hash wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
CommandFailedErroralready redacted the token from theCalledProcessErrorstring, but then appended decoded stderr without applying the same redaction. Some package managers include command details or authentication material in error output, so this keeps the failure message from re-exposing the token after the command string has been masked.Testing
python -m pytest tests/unit/customizations/codeartifact/test_adapter_login.py -q