Add MD5 to checksum-algorithm choices for s3 commands#10304
Open
shreyaskommuri wants to merge 1 commit into
Open
Add MD5 to checksum-algorithm choices for s3 commands#10304shreyaskommuri wants to merge 1 commit into
shreyaskommuri wants to merge 1 commit into
Conversation
MD5 is a valid checksum algorithm for S3 operations but was missing from the --checksum-algorithm choices list, causing the CLI to reject it with an invalid choice error before the request was made. This change adds MD5 to the accepted choices alongside the other supported algorithms (CRC32, SHA256, SHA1, etc.). Companion fix in botocore registers the Md5Checksum implementation so the checksum is computed correctly at the request layer. Fixes aws#10295 Generated by AI tools, and reviewed by shreyaskommuri
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10295. MD5 was missing from the
--checksum-algorithmchoices list for high-levels3commands (cp,sync,mv), causing the CLI to reject it with an invalid choice error before the request was even made.Changes:
MD5to theCHECKSUM_ALGORITHMchoices inawscli/customizations/s3/subcommands.pyRelated
A companion fix in botocore registers the
Md5Checksumimplementation so the checksum is computed correctly at the request layer: boto/botocore#3703Without that botocore fix,
s3apicommands would still fail for MD5 — both PRs are needed for a complete fix.Test plan
test_validate_checksum_algorithm_md5_uploadpassesDeveloped with AI assistance, reviewed and tested by shreyaskommuri