Fix PEP-765 violation: return in finally block#10092
Open
abhu85 wants to merge 1 commit intoaws:developfrom
Open
Fix PEP-765 violation: return in finally block#10092abhu85 wants to merge 1 commit intoaws:developfrom
abhu85 wants to merge 1 commit intoaws:developfrom
Conversation
Move `return True` outside of the `finally` block in LocalDeleteRequestSubmitter._submit_transfer_request() to comply with PEP-765 recommendations. This change preserves the exact same behavior (always returning True regardless of success or failure) while avoiding the SyntaxWarning that Python 3.14 emits for return statements in finally blocks. Fixes aws#9985 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the PEP-765 violation reported in #9985 by moving the
return Truestatement outside of thefinallyblock inLocalDeleteRequestSubmitter._submit_transfer_request().Problem
Python 3.14 (per PEP-765) emits a
SyntaxWarningforreturn,break, orcontinuestatements directly withinfinallyblocks. The current code has:Solution
Move the
return Trueafter thetry-exceptblock. This preserves the exact same behavior (always returningTrueregardless of success or failure) while avoiding the warning.Behavior Verification
Trueto indicate the transfer was submittedQueuedResultandSuccessResult, then returnsTrueQueuedResultandFailureResult, then returnsTrueBoth existing tests (
test_submitandtest_submit_with_exception) verify this behavior and pass.Test Plan
TestLocalDeleteRequestSubmittertests passSyntaxWarningwhen importing the moduleawscli/$ python -m pytest tests/unit/customizations/s3/test_s3handler.py::TestLocalDeleteRequestSubmitter -v # 5 passedFixes #9985