Skip to content

Update CloudTrail validate-logs for full key query range#10073

Merged
AndrewAsseily merged 1 commit intoaws:v2from
IanLeeYT:cloudtrail-validate-logs-query-range-v2
Feb 20, 2026
Merged

Update CloudTrail validate-logs for full key query range#10073
AndrewAsseily merged 1 commit intoaws:v2from
IanLeeYT:cloudtrail-validate-logs-query-range-v2

Conversation

@IanLeeYT
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
There exists an edge case in the CloudTrail validate-logs command where the script fails to query all CloudTrail public keys to validate the digest signature. It can happen when the command end time lands right after the rotation instant. Fix is to add a two hour buffer period.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@IanLeeYT IanLeeYT marked this pull request as ready for review February 12, 2026 17:26
Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ian! Looks good. Could you just add a changelog entry, something like:

'''
{
"category": "cloudtrail",
"description": "Fixed edge case in validate-logs where digest validation could fail with "public key not found" when the end time lands near a key rotation boundary",
"type": "bugfix"
}
'''

@IanLeeYT IanLeeYT force-pushed the cloudtrail-validate-logs-query-range-v2 branch from 3be1ed9 to 3e6ec6f Compare February 20, 2026 17:38
@IanLeeYT IanLeeYT force-pushed the cloudtrail-validate-logs-query-range-v2 branch from 3e6ec6f to 98fbdd6 Compare February 20, 2026 17:43
Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@AndrewAsseily AndrewAsseily merged commit 1be2991 into aws:v2 Feb 20, 2026
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments