Skip to content

Comments

Update CloudTrail validate-logs for full key query range#10072

Merged
AndrewAsseily merged 1 commit intoaws:developfrom
IanLeeYT:cloudtrail-validate-logs-query
Feb 20, 2026
Merged

Update CloudTrail validate-logs for full key query range#10072
AndrewAsseily merged 1 commit intoaws:developfrom
IanLeeYT:cloudtrail-validate-logs-query

Conversation

@IanLeeYT
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
There exists an edge case in the CloudTrail validate-logs command where the script fails to query all CloudTrail public keys to validate the digest signature. It can happen when the command end time lands right after the rotation instant. Fix is to add a two hour buffer period.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.40%. Comparing base (c4681b5) to head (a373c3f).
⚠️ Report is 137 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10072      +/-   ##
===========================================
+ Coverage    93.39%   93.40%   +0.01%     
===========================================
  Files          210      210              
  Lines        17052    17139      +87     
===========================================
+ Hits         15925    16009      +84     
- Misses        1127     1130       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IanLeeYT IanLeeYT marked this pull request as ready for review February 12, 2026 17:26
Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ian! Looks good. Could you just add a changelog entry, here as well? Also something like:

'''
{
"category": "cloudtrail",
"description": "Fixed edge case in validate-logs where digest validation could fail with "public key not found" when the end time lands near a key rotation boundary",
"type": "bugfix"
}
'''

@IanLeeYT IanLeeYT force-pushed the cloudtrail-validate-logs-query branch from 97b1f5a to a373c3f Compare February 20, 2026 17:41
Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@AndrewAsseily AndrewAsseily merged commit 084f934 into aws:develop Feb 20, 2026
48 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Feb 20, 2026
* release-1.44.44:
  Bumping version to 1.44.44
  Update changelog based on model updates
  Update CloudTrail validate-logs for full key query range (#10072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants