Update CloudTrail validate-logs for full key query range#10072
Merged
AndrewAsseily merged 1 commit intoaws:developfrom Feb 20, 2026
Merged
Update CloudTrail validate-logs for full key query range#10072AndrewAsseily merged 1 commit intoaws:developfrom
AndrewAsseily merged 1 commit intoaws:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10072 +/- ##
===========================================
+ Coverage 93.39% 93.40% +0.01%
===========================================
Files 210 210
Lines 17052 17139 +87
===========================================
+ Hits 15925 16009 +84
- Misses 1127 1130 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AndrewAsseily
requested changes
Feb 20, 2026
Contributor
AndrewAsseily
left a comment
There was a problem hiding this comment.
Thanks Ian! Looks good. Could you just add a changelog entry, here as well? Also something like:
'''
{
"category": "cloudtrail",
"description": "Fixed edge case in validate-logs where digest validation could fail with "public key not found" when the end time lands near a key rotation boundary",
"type": "bugfix"
}
'''
97b1f5a to
a373c3f
Compare
aws-sdk-python-automation
added a commit
that referenced
this pull request
Feb 20, 2026
* release-1.44.44: Bumping version to 1.44.44 Update changelog based on model updates Update CloudTrail validate-logs for full key query range (#10072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
There exists an edge case in the CloudTrail validate-logs command where the script fails to query all CloudTrail public keys to validate the digest signature. It can happen when the command end time lands right after the rotation instant. Fix is to add a two hour buffer period.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.