Skip to content

fix(memory): use --id for memory selectors - #2019

Open
notgitika wants to merge 1 commit into
aws:refactorfrom
notgitika:fix/memory-id-flags
Open

fix(memory): use --id for memory selectors#2019
notgitika wants to merge 1 commit into
aws:refactorfrom
notgitika:fix/memory-id-flags

Conversation

@notgitika

@notgitika notgitika commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

This PR standardize the parent Memory selector on --id across event, record, actor, and session commands. We see this convention in the rest of the CLI.

I also add a regression assertion that imperative Memory selectors do not use --memory

bun build, typecheck, lint, format and test pass

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 18, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.06%. Comparing base (a317a83) to head (44d1e06).

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2019   +/-   ##
=========================================
  Coverage     97.06%   97.06%           
=========================================
  Files           374      374           
  Lines         22542    22542           
=========================================
  Hits          21880    21880           
  Misses          662      662           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants