-
Notifications
You must be signed in to change notification settings - Fork 72
feat: implement project deploy command #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
notgitika
wants to merge
4
commits into
refactor
Choose a base branch
from
feat/project-deploy
base: refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,605
−102
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3253ab0
feat(project): implement project deploy
notgitika 5ae34c8
feat(project): deploy one target per invocation
notgitika 78348f6
refactor(project): load the CDK toolkit lazily and test the adapter
notgitika 5e56870
fix(project): ship the toolkit's bootstrap template with the artifacts
notgitika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Reads the cloud assembly `build` synthesized, so deploy can find the stack that | ||
| // belongs to a deployment target. | ||
| import { existsSync } from "node:fs"; | ||
| import { join } from "node:path"; | ||
| import z from "zod"; | ||
| import { ProjectStateError } from "../../errors/errors"; | ||
| import type { ReadWriteJson } from "../../io"; | ||
|
|
||
| // The tag the generated CDK app puts on every stack, naming the deployment target | ||
| // the stack was synthesized for. Selecting on it means the CLI never has to | ||
| // reproduce the app's stack-naming convention, so a project that renames its | ||
| // stacks still deploys. | ||
| const TARGET_TAG = "agentcore:target-name"; | ||
|
|
||
| const STACK_ARTIFACT = "aws:cloudformation:stack"; | ||
|
|
||
| // Only the parts of the manifest deploy reads. Artifacts are keyed by their | ||
| // hierarchical id, which is what the CDK toolkit matches stack patterns against. | ||
| const AssemblyManifestSchema = z.object({ | ||
| artifacts: z | ||
| .record( | ||
| z.string(), | ||
| z.object({ | ||
| type: z.string(), | ||
| properties: z.object({ tags: z.record(z.string(), z.string()).optional() }).optional(), | ||
| }), | ||
| ) | ||
| .default({}), | ||
| }); | ||
|
|
||
| /** | ||
| * The name of the stack in the synthesized assembly that belongs to `target`. | ||
| * | ||
| * The generated CDK app synthesizes one stack per deployment target and tags each | ||
| * with the target's name, so deploy asks the assembly which stack to ship rather | ||
| * than deriving the name itself and hoping the two agree. | ||
| */ | ||
| export async function stackForTarget( | ||
| json: ReadWriteJson, | ||
| assemblyDirectory: string, | ||
| target: string, | ||
| ): Promise<string> { | ||
| const path = join(assemblyDirectory, "manifest.json"); | ||
| // deploy synthesizes immediately before this, so a missing manifest means synth | ||
| // wrote somewhere else entirely rather than that the user skipped a step. | ||
| if (!existsSync(path)) { | ||
| throw new ProjectStateError(`No synthesized cloud assembly was found at ${path}.`); | ||
| } | ||
|
|
||
| const manifest = await json.read(path, AssemblyManifestSchema); | ||
| const stacks = Object.entries(manifest.artifacts).filter( | ||
| ([, artifact]) => artifact.type === STACK_ARTIFACT, | ||
| ); | ||
| const match = stacks.find(([, artifact]) => artifact.properties?.tags?.[TARGET_TAG] === target); | ||
| if (!match) { | ||
| throw new ProjectStateError( | ||
| `The synthesized cloud assembly has no stack for deployment target '${target}'. ` + | ||
| `${path} defines ${stacks.length} stack(s), none tagged ${TARGET_TAG}='${target}'.`, | ||
| ); | ||
| } | ||
| return match[0]; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the synth output the stack name? Is there a reason we need to re-derive it here?