fix(ci): upload both GA and preview tarballs in prerelease workflow#1386
Merged
Conversation
The bundle script now produces two tarballs (GA + preview) but the prerelease workflow only uploaded the first one it found. Upload both and include install commands in the release notes. Constraint: bundle.mjs names GA as *-<timestamp>.tgz and preview as *-preview-<timestamp>.tgz Confidence: high Scope-risk: narrow
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1386-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
agentcore-cli-automation
approved these changes
May 26, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Reviewed the workflow change. The tarball naming logic correctly distinguishes between GA (aws-agentcore-<base>-<timestamp>.tgz) and preview (aws-agentcore-<base>-preview-<timestamp>.tgz) artifacts produced by scripts/bundle.mjs, and grep -v preview is the effective differentiator since both names match the digit-suffix glob. The notes heredoc indentation works out correctly after YAML block-scalar stripping (10 spaces) — the rendered markdown will have flush-left fenced code blocks. Concurrency group prevents the delete-then-create race.
LGTM.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
The test starts a dev server, waits up to 20s for health check, then runs two invoke calls. On slow CI runners 30s total is insufficient. Confidence: high Scope-risk: narrow
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Hweinstock
approved these changes
May 26, 2026
| devProcess.kill('SIGTERM'); | ||
| devProcess = null; | ||
| }, | ||
| 30000 |
Contributor
There was a problem hiding this comment.
is this an unrelated fix? I saw this timing out so I think its welcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prerelease-tarballworkflow now uploads both the GA and preview tarballs to theprereleaseGitHub release tagnpm run bundleadded in feat: compile-time feature flag for preview/GA consolidation #1341Test plan
workflow_dispatchand verify both tarballs appear on theprereleasereleasenpm install -g <ga-url>npm install -g <preview-url>agentcore invoke --helpon GA build shows no harness optionsagentcore invoke --helpon Preview build shows harness options