New serverless pattern - appsync-events-lambda-agentcore#2990
Open
pjdavis-aws wants to merge 25 commits intoaws-samples:mainfrom
Open
New serverless pattern - appsync-events-lambda-agentcore#2990pjdavis-aws wants to merge 25 commits intoaws-samples:mainfrom
pjdavis-aws wants to merge 25 commits intoaws-samples:mainfrom
Conversation
added 19 commits
March 11, 2026 12:22
- Wire http_request, calculator, and current_time tools into the agent entrypoint with an updated system prompt - Add strands-agents-tools dependency to requirements - Add integration tests: test_http_request_tool, test_calculator_tool, test_current_time_tool - Print streaming chunks in _collect_response for visibility with -s - Rework session test to use web fetch for more realistic multi-turn
…, and auth section
ellisms
requested changes
Apr 14, 2026
Contributor
ellisms
left a comment
ellisms
left a comment
There was a problem hiding this comment.
Hi @pjdavis-aws - thanks for the submission. Requesting a few changes. Also, one of the integration tests fails and the console-based test fails to deliver the message to the subscriber. I don't see any errors in the Lambda logs.
| 1. Delete the stack | ||
| ``` | ||
| cdk destroy | ||
| ``` |
Contributor
There was a problem hiding this comment.
Add instruction to answer 'y' at the confirmation prompt.
| "layers": [powertools_layer], | ||
| "environment": { | ||
| "POWERTOOLS_SERVICE_NAME": construct_id, | ||
| "LOG_LEVEL": "DEBUG", |
Contributor
There was a problem hiding this comment.
INFO is probably more appropriate here.
|
|
||
| ```bash | ||
| pytest tests/unit -v # unit tests (no deployed stack needed) | ||
| pytest tests/integration -v -s # integration tests with streaming output |
Contributor
There was a problem hiding this comment.
test_conversation_with_session fails with the following:
> assert complete_2 is not None, "Turn 2 did not complete"
E AssertionError: Turn 2 did not complete
E assert None is not None
tests/integration/test_appsync_events.py:116: AssertionError
========================================================= short test summary info =========================================================
FAILED tests/integration/test_appsync_events.py::test_conversation_with_session - AssertionError: Turn 2 did not complete
Author
There was a problem hiding this comment.
I'll extend the timeout on the tests, this looks to be a latency issue somewhere.
|
|
||
| Figure 3 - AppSync Pub/Sub Editor - Publish panel | ||
|
|
||
| 1. Scroll back down to the bottom of the page to watch the subscription panel — you should see streaming chunk events arrive in real time, followed by a final completion event containing the full response. |
Contributor
There was a problem hiding this comment.
This did not work for me. I successfully subscribed, but the published messages are not being received.
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Real-time streaming chat using AppSync Events, Lambda, and Bedrock AgentCore Runtime. A Strands agent streams AI responses token-by-token to clients over WebSockets.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.