Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cdk/bootstrap/bootstrap-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1002,6 +1002,8 @@ Resources:
- lambda:GetFunctionCodeSigningConfig
- lambda:GetFunctionRecursionConfig
- lambda:GetProvisionedConcurrencyConfig
- lambda:PutProvisionedConcurrencyConfig
- lambda:DeleteProvisionedConcurrencyConfig
- lambda:GetRuntimeManagementConfig
- lambda:ListVersionsByFunction
- lambda:InvokeFunction
Expand Down
2 changes: 2 additions & 0 deletions cdk/bootstrap/policies/application.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
"lambda:GetFunctionCodeSigningConfig",
"lambda:GetFunctionRecursionConfig",
"lambda:GetProvisionedConcurrencyConfig",
"lambda:PutProvisionedConcurrencyConfig",
"lambda:DeleteProvisionedConcurrencyConfig",
"lambda:GetRuntimeManagementConfig",
"lambda:ListVersionsByFunction",
"lambda:InvokeFunction",
Expand Down
2 changes: 2 additions & 0 deletions cdk/src/bootstrap/policies/application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ export function applicationPolicy(): iam.PolicyDocument {
'lambda:GetFunctionCodeSigningConfig',
'lambda:GetFunctionRecursionConfig',
'lambda:GetProvisionedConcurrencyConfig',
'lambda:PutProvisionedConcurrencyConfig',
'lambda:DeleteProvisionedConcurrencyConfig',
'lambda:GetRuntimeManagementConfig',
'lambda:ListVersionsByFunction',
'lambda:InvokeFunction',
Expand Down
14 changes: 14 additions & 0 deletions cdk/test/bootstrap/policies.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,20 @@ describe('IaCRole-ABCA-Application', () => {
);
});

it('grants Put/Delete provisioned-concurrency, not just Get (#409)', () => {
// The Slack-events function pins provisioned concurrency on its `live`
// alias, so the exec role needs Put (create/update) and Delete (removal),
// not only the Get verb. Get-without-Put rolled the deploy back with
// AccessDenied on lambda:PutProvisionedConcurrencyConfig.
const resolvedDoc = stack.resolve(doc);
const statements = resolvedDoc.Statement as Array<{ Action: string | string[] }>;
const allActions = statements.flatMap((s) =>
Array.isArray(s.Action) ? s.Action : [s.Action],
);
expect(allActions).toContain('lambda:PutProvisionedConcurrencyConfig');
expect(allActions).toContain('lambda:DeleteProvisionedConcurrencyConfig');
});

it('LambdaEventSourceMappings grants tagging (CDK event-source constructs tag the mapping)', () => {
// Regression guard for #407: DynamoDBEventSource (and peers) tag the
// created event source mapping, so the exec role needs Tag/UntagResource
Expand Down
2 changes: 2 additions & 0 deletions docs/design/DEPLOYMENT_ROLES.md
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,8 @@ DynamoDB tables, Lambda functions, API Gateway, Cognito, WAFv2, EventBridge, SQS
"lambda:GetFunctionCodeSigningConfig",
"lambda:GetFunctionRecursionConfig",
"lambda:GetProvisionedConcurrencyConfig",
"lambda:PutProvisionedConcurrencyConfig",
"lambda:DeleteProvisionedConcurrencyConfig",
"lambda:GetRuntimeManagementConfig",
"lambda:ListVersionsByFunction",
"lambda:InvokeFunction",
Expand Down
2 changes: 2 additions & 0 deletions docs/src/content/docs/architecture/Deployment-roles.md
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,8 @@ DynamoDB tables, Lambda functions, API Gateway, Cognito, WAFv2, EventBridge, SQS
"lambda:GetFunctionCodeSigningConfig",
"lambda:GetFunctionRecursionConfig",
"lambda:GetProvisionedConcurrencyConfig",
"lambda:PutProvisionedConcurrencyConfig",
"lambda:DeleteProvisionedConcurrencyConfig",
"lambda:GetRuntimeManagementConfig",
"lambda:ListVersionsByFunction",
"lambda:InvokeFunction",
Expand Down
Loading