properly set PKCE values if client_secret is not present in configura…#54
Open
htakemoto wants to merge 1 commit intoaws-samples:masterfrom
Open
properly set PKCE values if client_secret is not present in configura…#54htakemoto wants to merge 1 commit intoaws-samples:masterfrom
htakemoto wants to merge 1 commit intoaws-samples:masterfrom
Conversation
|
Just FYI, we discovered an issue with Authorisation Code Flow with PKCE in the context of a lambda. The code verifier and code challenge are randomly created on Lambda startup so if different lambda instances service the initial OIDC redirect and the subsequent callback / token exchange the IdP will 403 the token exchange request as the code verifier is from a different lambda. I believe that in this context, lambda is better suited to the Authorisation code flow rather than Authorisation code flow with PKCE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The following command (without client_secret params) works fine. However it generates "client_secret": "None" instead of "client_secret": null
python cli.py \ --client_id client-id \ --cloudfront_host cloudfront-host \ --idp_domain_name idp-domain-name \ --idp_name idpThe "None" value impacts on
auth.jsto set PKCE values (line 259)My change fixes PKCE auth flow.