Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws_lambda_powertools/utilities/parameters/ssm.py
Original file line number Diff line number Diff line change
Expand Up @@ -583,12 +583,12 @@ def _get_parameters_by_name_in_chunks(
diff = {key: value for key, value in batch.items() if key not in cache}

for chunk in slice_dictionary(data=diff, chunk_size=self._MAX_GET_PARAMETERS_ITEM):
response, possible_errors = self._get_parameters_by_name(
chunk_response, possible_errors = self._get_parameters_by_name(
parameters=chunk,
raise_on_error=raise_on_error,
decrypt=decrypt,
)
response.update(response)
response.update(chunk_response)
errors.extend(possible_errors)

return response, errors
Expand Down
20 changes: 20 additions & 0 deletions tests/functional/parameters/_boto3/test_utilities_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -2347,6 +2347,26 @@ def _get_parameters_by_name(
parameters.get_parameters_by_name(parameters=params)


def test_get_parameters_by_name_chunks(monkeypatch, config):
# GIVEN a batch of 12 parameters (more than max batch size of 10)
params = {f"param{i}": {} for i in range(12)}

class TestProvider(SSMProvider):
def __init__(self, boto_config: Config = config, **kwargs):
super().__init__(boto_config=boto_config, **kwargs)

def _get_parameters_by_name(self, parameters, raise_on_error=True, decrypt=False):
return {name: f"val_{name}" for name in parameters}, []

monkeypatch.setitem(parameters.base.DEFAULT_PROVIDERS, "ssm", TestProvider())

# WHEN get_parameters_by_name is called
result = parameters.get_parameters_by_name(parameters=params)

# THEN all parameters should be returned across chunks
assert len(result) == 12


def test_get_parameters_by_name_cache(monkeypatch, mock_name, mock_value, config):
# GIVEN we have a parameter to fetch but is already in cache
params = {mock_name: {}}
Expand Down