feat(project): Add contract-test-exceptions.json support - #1125
Open
ruslan-aws wants to merge 1 commit into
Open
ruslan-aws wants to merge 1 commit into
ruslan-aws wants to merge 1 commit into
Conversation
Scaffold contract-test-exceptions.json on init and include it in the submit package. Third-party publishers declare self-service contract-test exceptions in a contract-test-exceptions.json file at the project root. The test runner reads it from the submitted artifact and applies the exceptions for third-party namespaces only. cfn init scaffolds the file for resource projects with two example entries. Both are exceptions already granted by default to every third-party resource, so the generated file has no functional effect; it documents the expected shape and level of justification. The scaffold uses safewrite, so a publisher's edited file is never overwritten. Modules and hooks are unaffected. cfn submit includes the file in the artifact zip when present and skips it when absent, mirroring overrides.json, so older projects without the file continue to submit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffold contract-test-exceptions.json on init and include it in the submit package.
Third-party publishers declare self-service contract-test exceptions in a contract-test-exceptions.json file at the project root. The test runner reads it from the submitted artifact and applies the exceptions for third-party namespaces only.
cfn init scaffolds the file for resource projects with two example entries. Both are exceptions already granted by default to every third-party resource, so the generated file has no functional effect; it documents the expected shape and level of justification. The scaffold uses safewrite, so a publisher's edited file is never overwritten. Modules and hooks are unaffected.
cfn submit includes the file in the artifact zip when present and skips it when absent, mirroring overrides.json, so older projects without the file continue to submit.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.