Skip to content

fix: destructure stdout in Cron._readCrontab() #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avoidwork merged 2 commits into from
Aug 2, 2026
+8 −9
Merged

fix: destructure stdout in Cron._readCrontab() #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
777dcad
fix: destructure stdout in Cron._readCrontab()
avoidwork Aug 2, 2026
136f2ca
fix: remove unused stderr variable from _readCrontab destructuring
avoidwork Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/scheduler/cron.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,11 @@ export const Cron = {
*/
async _readCrontab() {
try {
return (
(await _execOverride("crontab -l 2>&1", {
encoding: "utf-8",
stdio: ["pipe", "pipe", "pipe"],
})) || ""
).trim();
const { stdout } = await _execOverride("crontab -l 2>&1", {
encoding: "utf-8",
stdio: ["pipe", "pipe", "pipe"],
});
return (stdout || "").trim();
} catch (_err) {
return "";
}
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/scheduler/cron.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ function mockExec(command, options) {

// Intercept crontab commands
if (command.includes("crontab -l")) {
return Promise.resolve(mockCrontabContent || "");
return Promise.resolve({ stdout: mockCrontabContent || "", stderr: "" });
}

if (command.includes("crontab -")) {
// Read from stdin (the content to install)
const stdin = options?.input || "";
mockCrontabContent = stdin;
return Promise.resolve("");
return Promise.resolve({ stdout: "", stderr: "" });
}

if (command.includes("which crontab")) {
return Promise.resolve("/usr/bin/crontab");
return Promise.resolve({ stdout: "/usr/bin/crontab", stderr: "" });
}

// Reject unknown commands to prevent hanging
Expand Down