fix: exempt shell tool from permission gating in buildToolConfig - #674
Merged
Conversation
The shell tool is essential for agents that need command execution (coding, debug, testing, etc.) and the sandbox permissions are already enabled in config. Adding it to the exempt case alongside clarify, executeCode, and sampling ensures it's always registered.
avoidwork
force-pushed
the
fix/shell-tool-exempt
branch
from
August 2, 2026 16:31
f8bb385 to
e2cc10f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
shelltool was being gated by sandbox permissions inbuildToolConfig, even though the permissions are already enabled in config. This caused the coding sub agent to seeexecute(from deepagents middleware) but notshell(the project's shell tool), leading to the error:Adding
shellto the exempt case alongsideclarify,executeCode, andsamplingensures it's always registered.Type of Change
Testing
Unit test updated to expect 10 tools instead of 9 with
filesystem:readpermission.Coverage
Checklist
npm run lintpassesDetails
Commit(s):
f8bb385 fix: exempt shell tool from permission gating in buildToolConfigChanged files:
src/tools/index.js,tests/unit/tool_index.test.jsRule 5.4: PR template at
.github/PULL_REQUEST_TEMPLATE.mdwas used. All sections filled.