Repository navigation
Answer new messages on sessions whose sidecar toolbox has crashed - #54
Open
josephschorr wants to merge 1 commit into
Open
josephschorr wants to merge 1 commit into
josephschorr wants to merge 1 commit into
Conversation
A parked session whose separate-pod sidecar was crash-looping never consumed a wake: the sidecar step returned early on every pass, ahead of the wake handling. Because a pending wake also suppresses the idle sweep, the session never slept or archived either, so the user's message went unanswered and its pods were never reaped. A sidecar recorded as terminally failed no longer gates the reconcile; the failure is already on status for the runner to surface, so the pass falls through, the wake is consumed and the runner is created. A sidecar that is merely starting still holds the runner, but no longer holds a pending wake. The runner now boots without a separate-pod sidecar recorded as terminally failed instead of polling for its IP and then failing the session; the tool refresher reports the failure and picks the sidecar up if it recovers.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parked session whose separately-running sidecar toolbox had crashed could not be woken: a new user message was never answered, and the session's leftover pods were never cleaned up.
Now a crashed sidecar toolbox no longer holds the session back. The new message wakes the session, the agent starts without that toolbox, and it tells the user the toolbox is unavailable. If the toolbox recovers, the agent picks it up. A toolbox that is still starting up no longer delays the wake either. Once the conversation goes quiet, the session sleeps and archives as usual.