Skip to content

Show what a linked agent gets, and refuse link downgrades - #51

Open
josephschorr wants to merge 1 commit into
feat/desktop-install-linksfrom
feat/desktop-install-link-review
Open

josephschorr wants to merge 1 commit into
feat/desktop-install-linksfrom
feat/desktop-install-link-review

Conversation

@josephschorr

Copy link
Copy Markdown
Member

Follow-up to #41, covering two items the security review left open. Stacked on #41; retarget to main once it merges.

The approval dialog says what the agent gets. Before the bundle's own name and description, the install-link dialog now lists what the agent and any bundled agents would be granted: MCP servers, sidecar toolboxes, sandbox tools, network access, credentials, the secrets the install will ask for, shared cluster resources, and bundled agents. Long lists are capped. Every entry is flattened like the rest of the bundle text, so none can forge a dialog line. If a bundle's contents can't be read, the link is refused instead of shown with a partial summary.

Links never downgrade. If a link points at an older version of an agent that's already installed, it's refused before the dialog, with a notification explaining how to roll back on purpose (the file picker or the CLI). An old release that's signed is still signed, so the signature check alone didn't prevent this. Upgrades now show which installed version they replace. If the installed version can't be read, the link is refused.

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
openagentprimitives Ignored Ignored Preview Nov 5, 2026 4:27pm UTC

Request Review

@josephschorr
josephschorr force-pushed the feat/desktop-install-links branch from fc5907e to eefb1a5 Compare October 30, 2026 23:03
The install-link approval dialog now lists what the agent graph would be
granted before the bundle's own name and description: MCP servers, sidecar
toolboxes, sandbox tools, network access, credentials, the Secrets the
install will ask for, shared cluster resources and bundled agents. Each line
is capped, and every entry is flattened like the rest of the bundle text so
none can forge a dialog line. A bundle whose contents cannot be read is
refused rather than summarized partially.

A link whose bundle is an older version of an agent already installed is
refused before the dialog: a signed old release is still signed, so a
rollback has to go through the file picker or the CLI. The dialog also shows
the installed version an upgrade replaces. If the installed version cannot
be read, the link is refused.
@josephschorr
josephschorr force-pushed the feat/desktop-install-link-review branch from 0e545e6 to 972dec7 Compare November 5, 2026 16:27
@josephschorr
josephschorr force-pushed the feat/desktop-install-links branch from eefb1a5 to a658bb5 Compare November 5, 2026 16:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant