fix: drop is_multi_factor_auth_enabled from SignUpRequest#4
Merged
lakhansamani merged 2 commits intoJul 23, 2026
Merged
Conversation
Server removed the field from SignUpRequest in schema and proto (reserved field 15) as a security fix: it let unauthenticated signup callers disable MFA-on-by-default for their own new account. authorizerdev/authorizer#710, released 2.4.0-rc.6. Setting it now errors on GraphQL (unknown input field) and is silently dropped on REST/gRPC, so the SDK field was dead weight at best and misleading at worst. Vendored proto stubs still carry the old field 15; harmless since the SDK never sets it on the wire, but a full proto re-vendor against the server's updated .proto is separate follow-up work. BREAKING CHANGE: SignUpRequest no longer accepts is_multi_factor_auth_enabled.
…actor-auth-enabled-signup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Server removed
is_multi_factor_auth_enabledfromSignUpRequestinthe GraphQL schema and proto (field 15, now
reserved) inauthorizerdev/authorizer#710, released as
2.4.0-rc.6. It was asecurity fix: the field let an unauthenticated signup caller bypass
the server's MFA-on-by-default policy for their own new account.
What
is_multi_factor_auth_enabledfromSignUpRequestinsrc/authorizer/types.py. It was the only place in the SDK'shand-written code (dispatch table, GraphQL query strings, request
types) that exposed this field on the signup path.
src/authorizer/_grpc/alone.They still declare field 15 as an active field (stale vs. the
server's now-
reservedslot), but the SDK never sets it on thewire (
ParseDict(..., ignore_unknown_fields=True)builds the protomessage from a dict that no longer contains the key), so this is
wire-safe either direction per proto3 semantics. A full re-vendor of
the generated stubs against the server's updated
.protois aseparate, larger pass — this repo has no scripted regen process
(no Makefile target / script found), so it needs the proper
toolchain rather than a hand-edit of generated files.
Scoped narrowly to this one breaking change; not a general SDK gap
fix.
Test plan
pip install -e ".[dev]"in a fresh venvpython -m pytest -q -m "not live"— 112 passed, 63 deselectedSignUpRequest.__dataclass_fields__no longercontains
is_multi_factor_auth_enabled