feat: add note to TokenRevokeRequest and TokenRevokeResponse about 20-token-per-call limit#169
Open
fabiohidekihirose wants to merge 1 commit into
Open
feat: add note to TokenRevokeRequest and TokenRevokeResponse about 20-token-per-call limit#169fabiohidekihirose wants to merge 1 commit into
fabiohidekihirose wants to merge 1 commit into
Conversation
…-token-per-call limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup ticket: https://app.clickup.com/t/9002222883/ENG-5662
Problem
There is an undocumented limitation on the /api/auth/token/revoke API call that silently restricts bulk revocation to 20 tokens per request (controlled by the token.revoke.count.max parameter). Customers wrongly believe that all tokens will be revoked with just one call; however, this is not the case, and they need to make multiple calls until the count drops to zero. This was discovered by a customer (Unisys-Resonatex) through an unpleasant experience during a security event that required the revocation of 350,000 tokens.
We also never told customers the safe way to do bulk revocation. Just looping the API without preparation can go wrong in multiple ways.
Java SDK (authlete-java-common)