Skip to content

feat: add note to TokenRevokeRequest and TokenRevokeResponse about 20-token-per-call limit#169

Open
fabiohidekihirose wants to merge 1 commit into
masterfrom
feat/add-revoke-cap-note
Open

feat: add note to TokenRevokeRequest and TokenRevokeResponse about 20-token-per-call limit#169
fabiohidekihirose wants to merge 1 commit into
masterfrom
feat/add-revoke-cap-note

Conversation

@fabiohidekihirose

Copy link
Copy Markdown

Clickup ticket: https://app.clickup.com/t/9002222883/ENG-5662

Problem

There is an undocumented limitation on the /api/auth/token/revoke API call that silently restricts bulk revocation to 20 tokens per request (controlled by the token.revoke.count.max parameter). Customers wrongly believe that all tokens will be revoked with just one call; however, this is not the case, and they need to make multiple calls until the count drops to zero. This was discovered by a customer (Unisys-Resonatex) through an unpleasant experience during a security event that required the revocation of 350,000 tokens.
We also never told customers the safe way to do bulk revocation. Just looping the API without preparation can go wrong in multiple ways.

Java SDK (authlete-java-common)

  • Add a note to TokenRevokeRequest class explaining the 20-per-call cap and that you need to loop
  • Add a note to TokenRevokeResponse#count field saying loop until this hits zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant