fix: Resolve hasNextPage() infinite loop when per_page is not specified #1279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This release fixes a critical pagination bug where
hasNextPage()caused infinite loops whenper_pagewas not explicitly specified.Bug Fix:
The
hasNextPage()function in paginated list methods was usingrequest?.per_page ?? 1instead ofrequest?.per_page ?? 50, causing it to incorrectly returntruewhen there were 1-49 items.Before (buggy):
After (fixed):
Affected Methods (now fixed):
roles.list(),clients.list(),actions.list()actions.triggers.bindings.list(),actions.versions.list()deviceCredentials.list(),flows.list(),forms.list()organizations.members.list(),organizations.members.roles.list()organizations.enabledConnections.list(),organizations.invitations.list()selfServiceProfiles.list(),userGrants.list(),users.list()users.authenticationMethods.list(),users.logs.list()users.organizations.list(),users.permissions.list(),users.roles.list()Other changes:
CustomPagerclass for flexible pagination patternsReferences
hasNextPage()uses incorrect default forper_pagecausing infinite loops #1259Testing
Checklist