Open
Conversation
Upgrade ajv from 6.12.6 to 8.18.0 and add ajv-formats companion
package for format keyword support extracted from core in v8.
Key changes:
- Update import path from 'ajv/lib/ajv' to 'ajv' (v8 package structure)
- Replace removed `nullable` constructor option with `strict: false` and
convert schema-level `nullable: true` to standard `type: ['string', 'null']`
- Add `unicodeRegExp: false` to avoid regex compilation errors with
existing URI patterns in themes handler
- Rewrite prompts customText schema to use propertyNames with enum
constraints instead of enumerating 195k+ property nodes
(81 languages x 36 prompts x 67 screens) which caused stack overflow
in v8's code generator.
- Update test assertions for v8 error message changes
("should" -> "must", minLength wording)
Contributor
|
Thank you for submitting this PR! We really appreciate your effort in helping us upgrade AJV from v6 to v8. We will review the changes shortly to verify the impact on auth0-deploy-cli and ensure a smooth transition without breaking changes. Thanks again for helping us keep the project secure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade ajv from 6.12.6 to 8.18.0 and add ajv-formats companion package for format keyword support extracted from core in v8. With this upgrade - although breaking - I try to address https://security.snyk.io/vuln/SNYK-JS-AJV-15274295.
🔧 Changes
ajvto version 8.18.0strict: false, unicodeRegExp: falseto be closer to the v6 behaviornullableconstructor option withstrict: falseand convert schema-levelnullable: trueto standardtype: ['string', 'null']unicodeRegExp: falseto avoid regex compilation errors with existing URI patterns in themes handler📚 References
ajv < 8.18.0🔬 Testing
The PR should not contain any change in business logic.
📝 Checklist