Open settings menu actions to relevant panes#67
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Enables status-bar menu actions to open the Settings window directly to a relevant pane (e.g., Profiles, Visual Style) by making the selected pane controllable from AppKit entry points.
Changes:
- Update status menu actions to request a specific
SettingsPanewhen opening Settings. - Add
selectedPaneto the shared settings view model and bind the SwiftUI sidebar selection to it. - Extend
SettingsWindowController.show(...)/AppDelegate.openSettings(...)to accept an optional pane to select on open.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/ClickLight/StatusController.swift | Routes “Manage Profiles…” / “Configure Custom Colors…” to Settings with a requested pane. |
| Sources/ClickLight/SettingsWindowController.swift | Adds pane selection support and moves selected-pane state into the view model. |
| Sources/ClickLight/ClickLightSettingsView.swift | Binds the Settings navigation selection to viewModel.selectedPane and exposes SettingsPane for cross-file use. |
| Sources/ClickLight/AppDelegate.swift | Wires status menu “open settings” callback through to openSettings(selecting:). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manage Profiles...on Profiles andConfigure Custom Colors...on Visual Style.Verification
swift build