-
Notifications
You must be signed in to change notification settings - Fork 17
Add code signing and notarization to Bun Compile workflow #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b2d7dca
Add bun-compile GitHub Action workflow
kjiang-ac 5a63113
temp: add push trigger for testing
kjiang-ac 6659b2a
fix: install npm package before bun compile
kjiang-ac 7d198cc
fix: patch process.argv[1] for bun compile compatibility
kjiang-ac 0753f6a
revert: remove process.argv[1] patch from entry point
kjiang-ac 6419df6
feat: add repository_dispatch trigger for automated npm sync
kjiang-ac 8e56c07
rename binary assets from auggie-bun-* to auggie-*
kjiang-ac 7e74922
fix: use clean artifact names without .exe suffix
kjiang-ac 741590c
fix: clean artifact names, re-add push trigger for testing
kjiang-ac 114d5ef
fix: update version fallback to 0.18.1
kjiang-ac e588669
fix: remove hardcoded version fallback, fail fast if no version provided
kjiang-ac 7307a0e
Add macOS code signing, notarization, and SHA-256 checksums to Bun co…
kjiang-ac 958c438
Merge branch 'main' into auggie-bun-compile-workflow
kjiang-ac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow submits for notarization but doesn’t staple the ticket afterwards. Without stapling, some users may still see Gatekeeper prompts/errors when running the downloaded binary offline.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.