Repository navigation
fix: align adapter Urclock metadata policy with CLI - #694
Draft
DRSDavidSoft wants to merge 1 commit into
Draft
DRSDavidSoft wants to merge 1 commit into
DRSDavidSoft wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libavrdude adapter firmware-write path omitted Urclock nometadata even though the CLI path supplies it. On the connected ATmega328P, libavrdude rejected the firmware identity bytes at the end of application flash as overlapping its metadata byte.
Add the matching option for Urclock flash writes, with a regression check that ISP does not receive the option.
Validation: focused programmer tests passed through the stable test runner using installed Go 1.27.1 and an external temporary modfile. The canonical go.mod is unchanged. The pinned Go 1.27.2 download returned HTTP 403, so that exact toolchain remains a CI gate.
This is a draft checkpoint because live coordinated updating has additional unresolved compatibility problems:
Next action: propagate backend selection through runtime/primary command options with tests, establish the upstream meaning of the AVRDUDE 8.3 padding marker before changing its verifier, then build and validate a coordinated update with the matching package. Do not relax readback verification generically.
The LED investigation uses the supported standalone guarded programming path with the MiniCore 8.0 CLI pair and a persistent host for rainbow streaming. Related: #693, #71, #390. No device backups, settings, or private logs are included.