Skip to content

style: update grid layout and card styles for better responsiveness#2

Open
sameterkanboz wants to merge 1 commit intoata-core:masterfrom
sameterkanboz:master
Open

style: update grid layout and card styles for better responsiveness#2
sameterkanboz wants to merge 1 commit intoata-core:masterfrom
sameterkanboz:master

Conversation

@sameterkanboz
Copy link
Copy Markdown

there was an overflow issue because of component's style.

existing behavior:

Screen.Recording.2026-03-28.at.22.56.44.mov

expected behavior:

Screen.Recording.2026-03-28.at.22.57.10.mov

Copilot AI review requested due to automatic review settings March 28, 2026 20:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Quick Start section’s layout styles to prevent horizontal overflow caused by the CodeWindow content and to improve responsive behavior within the grid/cards.

Changes:

  • Adjusted .qs-grid to use repeat(2, minmax(0, 1fr)) so grid columns can shrink without forcing overflow.
  • Added min-width: 0 to .qs-card to allow grid items to shrink below their content’s intrinsic width.
  • Constrained .qs-card .code-window with max-width: 100% while keeping spacing consistent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mertcanaltin
Copy link
Copy Markdown
Member

mertcanaltin commented Mar 30, 2026

Samet, thank you so much for your work. ❤️ Would you like to help with another issue?
Unfortunately, I didn't see that PR, the issue had already been resolved.

@sameterkanboz
Copy link
Copy Markdown
Author

Hey @mertcanaltin, i would be very happy to help you about another issues. Just create an issue and i'll take care of it.

About this pr i can close this pr without merge bcz i can see you already fixed this problem in this commit.

however, I’d strongly recommend reverting that commit and proceeding with this PR instead

as you know, using overflow-x: hidden is generally considered an anti-pattern:

html { scroll-behavior: smooth; overflow-x: hidden; }

@mertcanaltin
Copy link
Copy Markdown
Member

Great, could you possibly create a new PR that fixes the issue you mentioned? Reverting it might be a bit of a problem since there are so many commits on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants