Translation from edit on element by alexangelov14 · Pull Request #670 · asterics/AsTeRICS-Grid

alexangelov14 · 2025-11-05T21:59:11Z

This is related to issue #564

github-actions · 2025-11-05T22:00:41Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

Since it was related to translation decided to add the solution to this problem here. This is a referance to which problem im referencing since it didnt have linked issue number: Problem: Currently, to "get" all content of a grid set one has to go to 'translate grid', choose the 'show all grids' from the first dropdown and then use the 'copy column' option to get the words.

github-actions · 2025-11-06T23:28:53Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

github-actions · 2025-11-07T22:37:12Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

github-actions · 2025-11-13T23:04:05Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

github-actions · 2025-11-17T12:11:21Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

github-actions · 2025-12-05T15:01:50Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

github-actions · 2025-12-05T15:10:21Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

Since we moved the translation to the "General" tab its pointless to keep it.

github-actions · 2025-12-05T17:32:55Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

alexangelov14 · 2025-12-05T17:34:07Z

@klues for some reason it doesnt reflect on the new changes when it builds the pr. Any ideas what may be the case for that?

EDIT: there wasnt any issue. It happened to be a caching problem on my side.

…ation Switched the position of the accordions "Advanced options" and "Translation". Also in the "Translation" accordion made it so that when there is no other language used by the user to default to the first one in the all languages list.

github-actions · 2025-12-11T22:33:51Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

github-actions · 2025-12-12T18:10:46Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

klues

Thanks for your work! 👍
Please look at my comments.

klues · 2025-12-18T14:15:07Z

app/lang/i18n.de.json

  "clone": "Duplizieren",
  "export": "Exportieren",
+  "exportElementLabels": "Element-Beschriftungen exportieren",
+  "exportLabelsDescription": "Exportieren Sie alle Element-Beschriftungen aus Ihren Grids als einfache Textdatei. Dies ist nützlich, um einen Überblick über Ihr Vokabular zu erhalten oder für externe Verarbeitung.",


has nothing to do with the current issue/PR, has it? It's an interesting idea, but do you have any user request regarding this feature? All regarding this exportLabels functionality should be removed from this PR and added/discussed in another issue/PR.

klues · 2025-12-18T14:16:08Z

app/lang/i18n.de.json

there shouldn't be any changes to languages files except i18n.en.json - all other languages are managed via crowdin.

klues · 2025-12-18T14:29:01Z

src/vue-components/modals/editElementGeneral.vue

+            getLabelPlaceholder(locale) {
+                // If LIVE element, show special placeholder
+                if (this.gridElement.type === GridElement.ELEMENT_TYPE_LIVE) {
+                    return i18nService.t('canIncludePlaceholderLike');


this breaks something.
Normally the placeholder for live elements looks like this:

now looks like this:

so it's now interpreting the placeholders which should be visible in the text as actual placeholders for data.

probably needs some adaption in i18nService.t() to not pass params?! I don't know.

this is still broken. For live elements the placeholder should tell the user that the text can include a placeholder like {0}, now it only says text (Spanish) or similar. Go to "new special element -> Live element" to see it.
I would use just (Spanish) for the normal placeholders not text (Spanish), but probably a thing of personal preference.

klues · 2025-12-18T14:33:00Z

src/vue-components/modals/editElementGeneral.vue

+                    return i18nService.t('canIncludePlaceholderLike');
+                }
+
+                // If label exists in requested locale, no placeholder needed


can be removed - if there is a value, we don't see the placeholder

klues · 2025-12-18T14:33:46Z

src/vue-components/modals/editElementGeneral.vue

+                }
+
+                // Find first available label in another language
+                let availableLangs = Object.keys(this.gridElement.label).filter(lang => this.gridElement.label[lang]);


can also be removed, see comment in issue. Basically just always show Text ([current content lang])

klues · 2025-12-18T14:51:08Z

src/vue-components/modals/editElementGeneral.vue

            }
        },
        mounted() {
+            // Ensure gridElement has proper label and pronunciation structure


hmm, I don't think we really need this - I think we can trust that label and pronunciation is an object here. See GridElement.DEFAULTS in GridElement.js

klues · 2025-12-18T14:53:44Z

src/vue-components/modals/editElementGeneral.vue

        margin-top: 1em;
    }
+
+    .input-button {


gridTranslateModal.vue has a very similar CSS rule for the pronunciation play button. please unify and add it to some common CSS like custom.css or even better: extract the input field + play button to an extra component and use it here twice and in translate modal once.

klues · 2025-12-18T14:56:54Z

src/vue-components/modals/editElementGeneral.vue

+        pointer-events: auto;
+    }
+
+    .checkbox-label-small {


the select for the languages + show all languages checkbox should also be moved to an extra component and used everywhere, to prevent doing the same things (like computing currently shown languages etc.) at so many places.
But only do it if you want - since it's probably some work to do it everywhere...

klues · 2025-12-18T14:57:40Z

src/vue-components/modals/exportLabelsModal.vue

as said in other comment - should be included in this PR - is a separate issue / PR

klues · 2025-12-18T15:00:37Z

src/vue-components/modals/gridTranslateModal.vue

        padding: 0 1em;
        box-shadow: none;
        background-color: transparent;
+        cursor: pointer;


aren't these default values for buttons? so I don't understand why we need these changes.

github-actions · 2026-01-06T20:51:35Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

alexangelov14 · 2026-01-06T20:55:50Z

@klues can you check if i havent missed something from the comments. The stuff regarding the export labels was requested by ms-mialingvo from what i remember. It was talked somewhere in the comments of the issue itself, if im not wrong.

https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

alexangelov14 · 2026-01-21T15:14:26Z

@klues can you check the last changes whenever possible?

alexangelov14 · 2026-02-03T09:56:10Z

@klues could you please check out the latest changes and give me some feedback if needed?

klues · 2026-02-09T10:56:00Z

app/lang/i18n.en.json

  "clone": "Clone",
  "export": "Export",
+  "exportElementLabels": "Export element labels",
+  "exportLabelsDescription": "Export all element labels from your grids as a simple text file. This is useful for getting an overview of your vocabulary or for external processing.",


please remove all new labels which are not related to the current issue.

klues · 2026-02-09T10:57:27Z

src/vue-components/modals/editElementGeneral.vue

        <div class="row">
            <label class="col-sm-2" for="inputLabel">{{ $t('label') }}</label>
            <div class="col-sm-7">
-                <input type="text" class="col-12" id="inputLabel" v-focus @keydown.enter.exact="$emit('searchImage')" v-if="gridElement" v-model="gridElement.label[currentLang]" :placeholder="gridElement.type === GridElement.ELEMENT_TYPE_LIVE ? $t('canIncludePlaceholderLike') : ''"/>


here you removed the logic for the special placeholder if it's a live element - should be included in "getLabelPlaceholder()"

klues · 2026-02-09T10:59:04Z

src/vue-components/modals/editElementGeneral.vue

+                let langName = this.getLocaleTranslation(locale);
+                return `${i18nService.t('text')} (${langName})`;
+            },
+            getPronunciationPlaceholder(locale) {


seems like this method is never used

klues · 2026-02-09T10:59:27Z

src/vue-components/modals/editElementGeneral.vue

+                let label = this.gridElement.label[locale] || '';
+                let langName = this.getLocaleTranslation(locale);
+                if (label) {
+                    return `${langName} pronunciation of "${label}"`;


klues · 2026-02-09T10:59:43Z

src/vue-components/modals/editElementGeneral.vue

+                if (label) {
+                    return `${langName} pronunciation of "${label}"`;
+                }
+                return `${langName} pronunciation`;


klues · 2026-02-09T11:00:12Z

src/vue-components/modals/editElementGeneral.vue

+                return `${langName} pronunciation`;
+            },
+            getLocaleTranslation(locale) {
+                return i18nService.getTranslationAppLang(this.allLanguages.filter((lang) => lang.code === locale)[0]);


klues · 2026-02-09T11:02:53Z

Hi, I've added another review with some new comments. There are also many comments from my previous review, which were not adressed.

In addition to changing something in the code, please also reply to all of my comments (also "ok, done" is helpful) - so it's easier for me to see what you have done or changed.

github-actions · 2026-02-09T14:40:40Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

alexangelov14 · 2026-02-09T14:44:02Z

@klues went through all of the comments from Dec 18th and the new ones today. All the things should be addressed from my understanding. Nothing should've been missed. The only thing skipped is the part for "the select for the languages + show all languages checkbox" which was optional for now. Seems kinda pointless at this point to go through all of the comments and say the I've done them since thats what I'm saying here in this one. Will keep it in mind for other tasks/issues tho.

https://gridbeta-github.asterics-foundation.org/alexangelov14/-564-translation-on-element-level/pr

Translation from edit on element

5705e37

This is related to issue #564

Requested changes

aa59698

Show already used languages only for export element labels

32cb5af

Reverting the change to now show all languages on edit

83b48dd

Move translation to the general tab

b8a5d4b

Delete editElementTranslation.vue

fdbe16d

Since we moved the translation to the "General" tab its pointless to keep it.

Updated placeholders in edit element modal

9e6725c

alexangelov14 added needs-code-review needs-beta-review labels Dec 15, 2025

alexangelov14 requested a review from klues December 15, 2025 14:15

klues requested changes Dec 18, 2025

View reviewed changes

Requested code updates

2867aac

ms-mialingvo mentioned this pull request Feb 3, 2026

Pictograms: no lag time & inform user actively when pics are finished loading #715

Open

klues requested changes Feb 9, 2026

View reviewed changes

alexangelov14 added 2 commits February 9, 2026 16:35

Requested changes

2986ae6

Merge branch 'master' into #564-translation-on-element-level

15c02ac

Conversation

alexangelov14 commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

alexangelov14 commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

klues left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

alexangelov14 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexangelov14 commented Jan 21, 2026

Uh oh!

alexangelov14 commented Feb 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

klues commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

alexangelov14 commented Feb 9, 2026

alexangelov14 commented Dec 5, 2025 •

edited

Loading

alexangelov14 commented Jan 6, 2026 •

edited

Loading

klues commented Feb 9, 2026 •

edited

Loading