ci: remove dead OS conditional in release workflow#198
Merged
Conversation
The release job always runs on ubuntu-latest, making the if RUNNER_OS = Linux conditional always true and the else branch permanently unreachable. Simplify to a single unconditional xvfb-run call. Closes #195 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Simplifies the release GitHub Actions workflow by removing a permanently-unreachable OS conditional and always running VS Code extension tests under xvfb-run on Linux (the release job runs on ubuntu-latest).
Changes:
- Removed the
RUNNER_OSif/elseshell block from the release workflow test step. - Replaced it with a single unconditional
xvfb-run -a npm testinvocation.
You can also share your feedback on Copilot code review. Take the survey.
askpt
deleted the
repo-assist/fix-release-dead-code-195-419636f91409c0d9
branch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job always runs on ubuntu-latest, making the
if RUNNER_OS = Linux conditional always true and the else
branch permanently unreachable. Simplify to a single
unconditional xvfb-run call.
Closes #195
Closes #196
Closes #197
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com