Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlite-vec.c
Original file line number Diff line number Diff line change
Expand Up @@ -6987,7 +6987,7 @@ int vec0_metadata_filter_text(vec0_vtab * p, sqlite3_value * value, const void *
}

case VEC0_METADATA_OPERATOR_IN: {
size_t metadataInIdx = -1;
int metadataInIdx = -1;
for(size_t i = 0; i < aMetadataIn->length; i++) {
struct Vec0MetadataIn * metadataIn = &(((struct Vec0MetadataIn *) aMetadataIn->z)[i]);
if(metadataIn->argv_idx == argv_idx) {
Expand Down
21 changes: 21 additions & 0 deletions tests/test-metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -624,3 +624,24 @@ def _auth(op, p1, p2, p3, p4):
return _auth


def test_metadata_in_filter(db):
# Exercises the metadata `IN (...)` filter path (VEC0_METADATA_OPERATOR_IN).
# A not-found entry in that path indexed with a `size_t metadataInIdx = -1`
# (== SIZE_MAX) caused an out-of-bounds read; the `< 0` guard never fired
# for an unsigned type. The OOB is silent without a sanitizer, so this test
# asserts correct filtering and the ASan job turns the latent OOB fail-loud.
db.execute("create virtual table t using vec0(a float[2], label integer)")
db.executemany(
"insert into t(rowid, a, label) values (?, vec_f32(?), ?)",
[(i, f"[{i},{i}]", i % 3) for i in range(9)],
)
rows = db.execute(
"select rowid from t "
"where a match vec_f32('[0,0]') and k = 9 and label in (1, 2)"
).fetchall()
found = sorted(r[0] for r in rows)
# rowids with label (i % 3) in {1, 2}: 1,2,4,5,7,8
assert found == [1, 2, 4, 5, 7, 8]
assert all(r % 3 != 0 for r in found)