provider-upgrade-copilot-1.0.86 -> Primary

[arul28]

  Open in ADE  ·  ade/provider-upgrade-copilot-1-0-86-e39ddcdb branch  ·  PR #1260

---

---

Note

Medium Risk
Changes Copilot chat open path, permission-mode mapping, and session lifecycle for a preview provider; incorrect mode or capability gating could affect supervision and pooled sessions across Copilot versions.

Overview
Upgrades GitHub Copilot ACP integration to CLI 1.0.86 and centralizes install guidance on @github/copilot@1.0.86 across CLI registry, chat errors, and Settings.

Copilot now drives native ACP session config (mode, allow_all) via session/set_config_option, with ADE’s permission ladder mapped to Agent / Plan / Autopilot URLs. auto-edit and auto are downgraded to approval-gated Agent mode with user-facing degradation notes, and supervision treats those modes as default so unsupervised-write warnings stay honest.

The shared ACP host gates rejoin and close on the initialize handshake (resume/load/new, and whether to send session/close), so older Copilot builds that omit close keep pooled processes alive instead of being killed. Mode setup fails closed: a failed initial mode config aborts open, tears down the runtime, and never calls ready—avoiding chats that run with a broader posture than selected. Spawn plans continue to pass --model and --effort as process-global flags included in pool identity.

Fixtures, conformance tests, docs, and a runtime-coordinator test cover the new behavior.

^{Reviewed by Cursor Bugbot for commit 445faca. Configure here.}

Summary by CodeRabbit

• New Features

  • Added Copilot support for Agent, Plan, and experimental Autopilot modes.
  • Added Copilot configuration options for session mode and allow-all permissions.
  • Copilot now displays notices when requested autonomy must be reduced for safety.

• Bug Fixes

  • Improved session handling based on capabilities advertised by the connected agent.
  • Failed mode setup now closes the session and reports the error instead of continuing.

• Updates

  • Copilot installation now uses the validated CLI version 1.0.86.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
ade	Ignored	Preview	Sep 19, 2026 9:17pm UTC

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_4b7a40cd-8bfc-44b8-a05e-31dbb652f32c)

[coderabbitai]

Warning

Review limit reached

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: arul28/ADE/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: db4739c7-2b5d-41db-a3ad-482fb0b92a7d

📥 Commits

Reviewing files that changed from the base of the PR and between b94c036 and b8eeee8.

⛔ Files ignored due to path filters (2)

• docs/features/chat/acp-providers-spec.md is excluded by !docs/**
• docs/features/chat/acp-verification-brief.md is excluded by !docs/**

📒 Files selected for processing (1)

• apps/desktop/src/main/services/chat/acpHost/acpDialects/qwen.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: arul28/ADE/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 595981bf-069f-4327-b03d-7b560ddb488c

📥 Commits

Reviewing files that changed from the base of the PR and between 445faca and b94c036.

⛔ Files ignored due to path filters (2)

• docs/features/chat/acp-providers-spec.md is excluded by !docs/**
• docs/features/chat/acp-verification-brief.md is excluded by !docs/**

📒 Files selected for processing (4)

• apps/desktop/src/main/services/chat/acpHost/acpDialects/copilot.ts
• apps/desktop/src/main/services/chat/acpHost/acpHostTypes.ts
• apps/desktop/src/main/services/chat/acpHost/acpRuntimeCoordinator.test.ts
• apps/desktop/src/main/services/chat/acpHost/acpRuntimeCoordinator.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change updates Copilot ACP support for CLI 1.0.86. It adds native mode configuration, capability-based session handling, setup-failure cleanup, shared package metadata, and updated fixtures and tests.

Changes

Copilot ACP compatibility

Layer / File(s)	Summary
Baseline metadata and package wiring apps/desktop/src/shared/acpProviderMetadata.ts, apps/ade-cli/src/services/agentRegistry.ts, apps/desktop/src/main/services/chat/agentChatService.ts, apps/desktop/src/renderer/components/settings/providers/acpProviders.tsx, apps/desktop/src/main/services/chat/acpHost/fixtures/liveBinaryProbe.mjs, apps/desktop/src/main/services/chat/acpHost/acpHost.fixtures.test.ts	Defines the Copilot 1.0.86 compatibility baseline and derived npm package specification. Installation commands use the shared specification. Binary probing reads the version from initialization.
Native mode configuration apps/desktop/src/main/services/chat/acpHost/acpDialects/copilot.ts, apps/desktop/src/main/services/chat/acpHost/acpHostTypes.ts, apps/desktop/src/main/services/chat/acpHost/acpRuntimeCoordinator.ts, apps/desktop/src/main/services/chat/agentChatService.ts, apps/desktop/src/main/services/chat/acpHost/fixtures/copilot.config-options.json, apps/desktop/src/main/services/chat/acpHost/acpHost.test.ts, apps/desktop/src/main/services/chat/agentChatService.test.ts	Adds Copilot mode and configuration identifiers, maps ADE modes to protocol URLs, applies native mode values, and emits degradation notes for auto-edit and auto. Model fallback requires an advertised model option.
Capability-driven session lifecycle apps/desktop/src/main/services/chat/acpHost/acpProtocolTypes.ts, apps/desktop/src/main/services/chat/acpHost/acpSession.ts, apps/desktop/src/main/services/chat/acpHost/acpRuntimeCoordinator.ts, apps/desktop/src/main/services/chat/agentChatService.ts, apps/desktop/src/main/services/chat/acpHost/acpHost.test.ts, apps/desktop/src/main/services/chat/acpHost/acpRuntimeCoordinator.test.ts	Adds capability helpers and uses handshake capabilities to select session entry behavior and close behavior. Failed mode setup closes the session, invokes failure callbacks, and invalidates the cached runtime.
Compatibility fixtures and assertions apps/desktop/src/main/services/chat/acpHost/fixtures/copilot.initialize.json, apps/desktop/src/main/services/chat/acpHost/acpHost.fixtures.test.ts	Updates the Copilot fixture to version 1.0.86 with MCP transports and session/close support. Tests validate the new capabilities and configuration options.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Feature

Suggested labels: desktop, docs

Merge Risk: ⚪ Minimal · up to b94c0

No concrete merge-blocking risk remains. Required mode setup failures continue to report their original error after session cleanup.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 23.08% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 15 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the primary change: upgrading the Copilot provider to version 1.0.86. The trailing "-> Primary" is extra but does not make the title misleading.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_b0f8feb8-15f3-4261-a77e-2b849d557d1c)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_afa04013-5f7c-4813-995a-e738ff97acc9)

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_239e302b-ea3f-42dd-a11a-551ca4ead1f0)