Skip to content

test(e2e): sign out in the cookie smoke test even when it fails - #355

Merged
arrzdev merged 1 commit into
mainfrom
fix/smoke-cookie-signout-finally
Nov 17, 2026
Merged

arrzdev merged 1 commit into
mainfrom
fix/smoke-cookie-signout-finally

Conversation

@arrzdev

@arrzdev arrzdev commented Nov 17, 2026

Copy link
Copy Markdown
Owner

What

The session-cookie smoke test now signs out in a finally block, so sign-out runs whether the cookie assertion passes or fails. The sign-out status check uses expect.soft, so a failed sign-out still fails the test but never hides the cookie assertion error.

Why

Before, a failed cookie assertion skipped sign-out and left the QA account's session row in the database until it expired (7 days).

Verification

  • Forced the assertion to fail locally (expected samesite=strict, not committed) against production: the test failed and the sign-out request still returned 200.
  • Without the forced failure, the smoke passes against production.

The session cookie test signed out only after its assertions passed, so a failed run left the QA session row behind until it expired. Sign-out now runs in a finally block; its status check is soft so it never hides the assertion error.
@arrzdev
arrzdev merged commit f8ff2b2 into main Nov 17, 2026
6 checks passed
@arrzdev
arrzdev deleted the fix/smoke-cookie-signout-finally branch November 17, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant