Repository navigation
test(e2e): sign out in the cookie smoke test even when it fails - #355
Merged
Merged
Conversation
The session cookie test signed out only after its assertions passed, so a failed run left the QA session row behind until it expired. Sign-out now runs in a finally block; its status check is soft so it never hides the assertion error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The session-cookie smoke test now signs out in a
finallyblock, so sign-out runs whether the cookie assertion passes or fails. The sign-out status check usesexpect.soft, so a failed sign-out still fails the test but never hides the cookie assertion error.Why
Before, a failed cookie assertion skipped sign-out and left the QA account's session row in the database until it expired (7 days).
Verification
samesite=strict, not committed) against production: the test failed and the sign-out request still returned 200.