Repository navigation
test(e2e): assert the session cookie flags on a smoke sign-in - #352
Merged
Merged
Conversation
The deployed-environment smoke signs in with an existing QA account from E2E_QA_EMAIL and E2E_QA_PASSWORD, checks the session Set-Cookie carries Secure, HttpOnly and SameSite=Lax, then signs out. Skipped when the account is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The read-only production smoke now catches a session cookie that loses
Secure,HttpOnlyorSameSite=Lax.e2e/smoke.spec.ts: signs in with an existing QA account (E2E_QA_EMAIL,E2E_QA_PASSWORD), checks the attributes of the sessionSet-Cookie, then signs out. The only write is the session row, and sign-out deletes it.How to verify
Against production without a QA account: 8 passed, 4 skipped (the new test on each project). There is no QA account on production yet, so the new test skips until one exists.