Repository navigation
fix(backend): set the session cookie flags explicitly - #349
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
better-auth only adds
Secureto the session cookie whenBETTER_AUTH_URLstarts withhttps://. Production is https, so the cookie is Secure today, but nothing stops an http URL from quietly dropping the flag, and no test could notice because the test env uses an http base URL.The auth config now sets
Secure,HttpOnlyandSameSite=Laxthroughadvanced.defaultCookieAttributes. It does not useuseSecureCookies, because that also renames the cookie to__Secure-….The game signs in with bearer tokens, so making the cookie Secure on http dev doesn't change dev sign-in.
How to verify
pnpm --filter @repo/backend exec vitest run src/http/routes/auth.routes.test.ts -t cookie: the cookie test now also checksSecure. It fails on main (http base URL) and passes here.set-cookieon/api/v1/auth/sign-in/usernamecontainsSecure; HttpOnly; SameSite=Lax.UI quality gate
Does not apply: backend only.