Re-generate protobuf files to be compatible with google-protobuf v4.x#10
Re-generate protobuf files to be compatible with google-protobuf v4.x#10valscion wants to merge 2 commits intoarkency:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi @mostlyobvious or others — anything I could do here to get this over the finish line? We are still stuck to A new major version of Do you want some test coverage or something here? I've verified that |
https://github.com/protocolbuffers/protobuf/releases/tag/v26.0-rc3 The compiled Ruby files will no longer work with google-protobuf v4.26.0 that has been released March 12, 2024.
a172075 to
1e5a5b1
Compare
Result of: ``` cd lib/ protoc **/*.proto --ruby_out=. ```
1e5a5b1 to
cd7d1a1
Compare
|
@valscion on it today |
|
Let me know if there's anything more you need from me, happy to help |
|
For what it's worth, it does seem like these changes also worked with the 3.x version of |
$ cd lib/
$ protoc --version # libprotoc 25.7
$ protoc **/*.proto --ruby_out=lib/
> The protoc version can be inferred from the Protobuf Ruby minor version number.
> Example: Protobuf Ruby version 3.25.x uses protoc version 25.x.
This generates slightly different code, as the DSL is deprecated and
will be removed in newer protobuf releases.
Reference:
#10 (comment)
https://protobuf.dev/news/2023-04-20/
https://protobuf.dev/support/version-support/
|
Thank you for all the links and research you've done here — it was helpful. I had to remind myself the inner workings of protobuf and their versioning policy. The last version of google-protobuf 3.x targeted protoc in version I'll release Then continue bumping both: the |
|
Since I've rebased your PR , added minimal gem version requirement and will eventually release it as 2.0 |
|
Released v2.0.0 Let me know how it goes for you! |
|
Thank you! These changes should work for us, I don't see why not. I'll let you know once we get to upgrading our protobuf-related dependencies |
The compiled Ruby files will no longer work with google-protobuf v4.26.0 that has been released March 12, 2024.
The generated outcome is the result of