Corrected minor documentation issues and improved the result processing flow in tsToArray.ts.#58
Open
Leask wants to merge 3 commits intoariym:masterfrom
Open
Corrected minor documentation issues and improved the result processing flow in tsToArray.ts.#58Leask wants to merge 3 commits intoariym:masterfrom
tsToArray.ts.#58Leask wants to merge 3 commits intoariym:masterfrom
Conversation
This submission addresses the following two issues: 1. The first line is not always empty. Directly shifting the first line can cause processing failures for short audio clips. A better approach is to use a blank line filter to remove any potential empty lines. 2. A `null` model return does not necessarily indicate a runtime error. It may signify that some audio clips do not contain text recognizable by the model. In such cases, an empty response should be returned instead of triggering a code error. Related issues: 1: ariym#46 2: ariym#29
Leask
changed the title
Leask
changed the title
tsToArray.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.