Fixed parallaxing performance issues on Chrome by changing .logo to p…#3
Merged
arguiot merged 1 commit intoarguiot:masterfrom Oct 15, 2017
Merged
Fixed parallaxing performance issues on Chrome by changing .logo to p…#3arguiot merged 1 commit intoarguiot:masterfrom
arguiot merged 1 commit intoarguiot:masterfrom
Conversation
…osition:fixed, and making index.js animate .logo’s transform:translate, rather than top.
Owner
|
@all-contributors please add @andrewbash for design |
Contributor
|
I've put up a pull request to add @andrewbash! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logo parallax at the top of the docs page was really choppy on Chrome.
After some investigation I found that it was caused by
.logobeing assignedposition:relativerather thanposition:fixed.I changed that property, as well as the
topproperty being animated inindex.jstotransform:translateY()as this is a bit lighter weight on the browser.