Repository navigation
docs(user-stories): name every view the bilingual UI has - #428
Merged
Merged
Conversation
Section 3's last bullet claims a bilingual front end across "all pages"
and then names six: market, wallet, transactions, sharing, admin,
settings. The UI has eight.
ui/js/app.js:537-551 NAV dashboard / marketplace / sharing /
wallet / transactions / admin / ops /
settings
ui/js/app.js:555-562 VIEW_TITLE the same eight keys; VALID_VIEWS is
its key set (:565)
ui/js/i18n.js view.* all eight titles in both language
packages (zh :99-106, en :942-949)
The omission contradicts the document itself twice over. Line 38 of the
same list names the operator view ("enterprise controls: ... operator
view"), and the roles table at :13 describes it as a view of its own. It
also contradicts the README this section says it mirrors: README.md:20
and README.en.md:20 have listed all eight since #426.
The fix is one line: name all eight, in sidebar order, in the wording the
README already uses. No gate reads docs/user-stories.md -- grep -rn
user-stories src/ finds one comment in gift.rs -- so this corrects the
data without adding a guard, which is the axis' standing rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/user-stories.mdsection 3 is headed "capability list (mirrors the README features)", and its last bullet claims a bilingual front end across "all pages" while naming six: market / wallet / transactions / sharing / admin / settings. The UI has eight views, and the bullet omits the dashboard and the operator view.Three independent readers agree on the roster:
ui/js/app.js:537-551NAVui/js/app.js:555-562VIEW_TITLEVALID_VIEWSis its key set (:565)ui/js/i18n.jsview.*:99-106, en:942-949)The omission contradicts the document itself twice over, so it is not a different way of grouping the views:
:13describes it as a view of its own.README.md:20andREADME.en.md:20listed all eight in docs(readme): name the web views the UI actually has #426.The dashboard matters in particular because it is the view a user lands on after login —
app.js:575falls back todashboardfor any hash it does not recognise — so a reader asking "is the dashboard bilingual?" got "no" from this list.Related Issue
None. There is no open issue in this repository; the defect was found while reading the docs against the code.
Changes
docs/user-stories.md:40— name all eight views, in sidebar (NAV) order, in the wordingREADME.md:20already uses.The line is now name-for-name identical to
README.md:20's roster, which is what the section claims to mirror.Tests
cargo test— 579 passed, 0 failedcargo fmt --check— cleancargo clippy --all-targets— no warningsdocs/user-stories.md(grep -rn user-stories src/finds one comment ingift.rs). Correcting the data rather than pinning a wording is this axis' standing rule.Checklist
docs/)