Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Fix generating incorrect names for Jobs when generateName is used#718

Open
pnovitskiy wants to merge 3 commits into
argoproj:masterfrom
pnovitskiy:master
Open

Fix generating incorrect names for Jobs when generateName is used#718
pnovitskiy wants to merge 3 commits into
argoproj:masterfrom
pnovitskiy:master

use TrimFunc to keep only letters,numbers and dash

fc2c758
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Jun 23, 2026 in 0s

53.65% (-0.61%) compared to 8849c3f

View this Pull Request on Codecov

53.65% (-0.61%) compared to 8849c3f

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.65%. Comparing base (8849c3f) to head (fc2c758).
⚠️ Report is 70 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
- Coverage   54.26%   53.65%   -0.61%     
==========================================
  Files          64       64              
  Lines        6164     6476     +312     
==========================================
+ Hits         3345     3475     +130     
- Misses       2549     2725     +176     
- Partials      270      276       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.