Correct readLinearAcceleration function#2
Open
septatrix wants to merge 3 commits intoarduino-libraries:masterfrom
Open
Correct readLinearAcceleration function#2septatrix wants to merge 3 commits intoarduino-libraries:masterfrom
septatrix wants to merge 3 commits intoarduino-libraries:masterfrom
Conversation
changed typo to give back correct information like the other methods which read linearAccelData
trullock
suggested changes
Nov 18, 2019
trullock
left a comment
trullock
left a comment
There was a problem hiding this comment.
This definitely looks like a fix to a bug, but its a breaking change so there should be a version increment associated with this
|
|
Author
|
@arduino-libraries any chance to get this merged? |
per1234
added
type: imperfection
per1234
previously requested changes
May 20, 2022
Co-authored-by: per1234 <accounts@perglass.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed typo to give back correct information like the other methods which read linearAccelData