fix(ci): resolve smoke test race condition and add explicit CodeQL workflow#308
Merged
Merged
Conversation
…rkflow The Validate and Release workflows trigger concurrently on release-commit pushes to main. Smoke tests that naively query the latest release tag get a 404 because release-binaries.yml hasn't uploaded the platform assets yet. Fix the race by iterating recent releases and selecting the first one that has the expected asset uploaded. Also add an explicit CodeQL workflow to replace GitHub's default setup, which silently skipped PR #279 and dropped the Scorecard SAST score to 9/10. Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
Deploying archgate-cli with
|
| Latest commit: |
d7ba226
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8123f943.archgate-cli.pages.dev |
| Branch Preview URL: | https://fix-ci-smoke-test-race-and-c.archgate-cli.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Note: Disabled the CodeQL "default setup" via the API ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh release viewto get the latest tag, but the release binaries hadn't been uploaded yet — causing a 404. Fixed by iteratinggh release list --limit 5and selecting the first release with the expected platform asset (archgate-win32-x64.zip/archgate-linux-x64.tar.gz)..github/workflows/codeql.ymlthat runs on push, PR, and weekly schedule to guarantee coverage.codeql-action/upload-sarifinscorecard.ymlfrom v4.35.3 to v4.35.4 for consistency.Post-merge action
After merging, disable the CodeQL "default setup" in Settings > Code security > Code scanning to avoid duplicate analyses.
Test plan
javascript-typescriptandactions