STDP case for busyring benchmark by jlubo · Pull Request #2489 · arbor-sim/arbor

jlubo · 2025-12-23T16:34:16Z

Adds a STDP case for the busyring benchmark (also cf. here).

thorstenhater · 2026-01-05T15:43:38Z

Hi @jlubo,

there are some broken numpy functions in master. Please take a look at #2490 and rebase.

jlubo · 2026-01-21T19:49:56Z

The rebase is done.

thorstenhater

Thanks. If you want to pull out the config thing into a new PR,
feel free do so. I left a few comments on the rest.

T

thorstenhater · 2026-01-27T14:37:54Z

    }
 };

+std::string get_arbor_config_str() {


This is usually intended only for use in Python. However, I see the usefulness of providing this to the user at runtime.

thorstenhater · 2026-01-27T14:43:46Z


    // Add a synapse to proximal end of first dendrite.
-    decor.place(arb::mlocation{1, 0}, arb::synapse{"expsyn"}, "p");
+    decor.place(arb::mlocation{0, 1}, arb::synapse{"expsyn"}, "p");


These locations are equivalent soma(1) ~ dend(0).

thorstenhater · 2026-01-27T14:47:47Z

        std::uniform_real_distribution<float> delay_dist(0, 2*min_delay_);
        auto src_gen = std::mt19937(gid);
-        for (unsigned i=1; i<ncons; ++i) {
+        for (unsigned i=0; i<ncons; ++i) {


This seems wrong; we got one connection from the ring, thus n-1 random ones.

Yeah... I've now adapted the synapses parameter to consistently count the random synapses only. So in this sense it should be correct. But I hope this doesn't conflict with any previous uses of busyring? The thing is that this is how it's described in our paper (and also implemented in the coreneuron example). The alternative would be to change the number of synapses in all *.json files.

Well, it depends ;) Previously, we did count all synapses and all other instantiations of busyring do remain doing so. I'd prefer consistency, if it's ok.

…and documentation improvement

…d in separate PR

thorstenhater

Could you match the synapse count to the protocol of all the other examples? I am a bit worried that using two approaches is confusing.

…connection)

jlubo · 2026-04-08T16:33:41Z

Could you match the synapse count to the protocol of all the other examples? I am a bit worried that using two approaches is confusing.

Done. Sorry for the delay. I've now also adjusted the protocol in the related CoreNEURON implementation.

thorstenhater

Thanks!

@thorstenhater

# Preliminary release notes for v0.12 ## What's Changed * V0.11.0 rc by @thorstenhater in #2454 * Release finalisation by @thorstenhater in #2455 * CSCS CI by @thorstenhater in #2448 * Re-factor connection setup and event dispatch. by @thorstenhater in #2449 * Add tiled busyring by @thorstenhater in #2456 * Fill in a missing part of the docs by @thorstenhater in #2462 * Major Optimisations in Label Resolution by @thorstenhater in #2458 * Refactor domain decomposition by @thorstenhater in #2457 * Add an escape hatch to label resolution by @thorstenhater in #2459 * Fix crash on probding elided values by @thorstenhater in #2466 * Only store PRNG data if needed by @thorstenhater in #2467 * 🐍 Polish `label_dict` by @thorstenhater in #2451 * use better builtins for double max/min by @thorstenhater in #2469 * Remove typed map and refactor cable cell by @thorstenhater in #2468 * Many small refactoring / clean-ups / memory savings by @thorstenhater in #2465 * Bump pb11 to latest major version by @thorstenhater in #2475 * Fix GPU test issues by @ibanezbm in #2479 * Align versions by @thorstenhater in #2481 * Add probing of eX. by @thorstenhater in #2478 * Add trivial compiler test by @thorstenhater in #2488 * Replace MPI_Allgatherv with MPI_Alltoallv for communication pattern by @ibanezbm in #2460 * Use CBRNG in schedules. by @thorstenhater in #2386 * Update year 🎉 by @thorstenhater in #2491 * Don't use deprecated numpy functions by @thorstenhater in #2490 * Co-simulation tutorial by @thorstenhater in #2492 * Nested timers by @marvinKaster in #2486 * Clean-up iclamp interface by @thorstenhater in #2494 * Fix override by @thorstenhater in #2493 * Better use of __restrict__ by @thorstenhater in #2476 * Add AdEx cells. by @thorstenhater in #2230 * units in cv policy by @thorstenhater in #2495 * Flat map in mechanism description for 1.5x speed-up in synapse creation by @thorstenhater in #2501 * Perf/compress contiguous by @thorstenhater in #2470 * Allow more SWC files in the parser by @thorstenhater in #2471 * STDP case for busyring benchmark by @jlubo in #2489 * round robin load balance by @thorstenhater in #2500 ## New Contributors * @ibanezbm made their first contribution in #2479 * @marvinKaster made their first contribution in #2486 **Full Changelog**: v0.11.0...v0.12.0

@thorstenhater

# Release notes This release constitutes a major improvement in terms of parallel performance by replacing the underlying MPI algorithm (see our paper at IPDPS'26) and setup time by improving label resolution and adding the access to raw labels. On the functional side, we introduced AdEx cells, added a new load balancing method, and probes for the reversal potential. ## What's Changed * V0.11.0 rc by @thorstenhater in #2454 * Release finalisation by @thorstenhater in #2455 * CSCS CI by @thorstenhater in #2448 * Re-factor connection setup and event dispatch. by @thorstenhater in #2449 * Add tiled busyring by @thorstenhater in #2456 * Fill in a missing part of the docs by @thorstenhater in #2462 * Major Optimisations in Label Resolution by @thorstenhater in #2458 * Refactor domain decomposition by @thorstenhater in #2457 * Add an escape hatch to label resolution by @thorstenhater in #2459 * Fix crash on probding elided values by @thorstenhater in #2466 * Only store PRNG data if needed by @thorstenhater in #2467 * 🐍 Polish `label_dict` by @thorstenhater in #2451 * use better builtins for double max/min by @thorstenhater in #2469 * Remove typed map and refactor cable cell by @thorstenhater in #2468 * Many small refactoring / clean-ups / memory savings by @thorstenhater in #2465 * Bump pb11 to latest major version by @thorstenhater in #2475 * Fix GPU test issues by @ibanezbm in #2479 * Align versions by @thorstenhater in #2481 * Add probing of eX. by @thorstenhater in #2478 * Add trivial compiler test by @thorstenhater in #2488 * Replace MPI_Allgatherv with MPI_Alltoallv for communication pattern by @ibanezbm in #2460 * Use CBRNG in schedules. by @thorstenhater in #2386 * Update year 🎉 by @thorstenhater in #2491 * Don't use deprecated numpy functions by @thorstenhater in #2490 * Co-simulation tutorial by @thorstenhater in #2492 * Nested timers by @marvinKaster in #2486 * Clean-up iclamp interface by @thorstenhater in #2494 * Fix override by @thorstenhater in #2493 * Better use of __restrict__ by @thorstenhater in #2476 * Add AdEx cells. by @thorstenhater in #2230 * units in cv policy by @thorstenhater in #2495 * Flat map in mechanism description for 1.5x speed-up in synapse creation by @thorstenhater in #2501 * Perf/compress contiguous by @thorstenhater in #2470 * Allow more SWC files in the parser by @thorstenhater in #2471 * STDP case for busyring benchmark by @jlubo in #2489 * round robin load balance by @thorstenhater in #2500 ## New Contributors * @ibanezbm made their first contribution in #2479 * @marvinKaster made their first contribution in #2486 **Full Changelog**: v0.11.0...v0.12.0

jlubo requested a review from thorstenhater December 23, 2025 16:34

thorstenhater and others added 10 commits January 21, 2026 20:29

make stdp an option

1d4e50c

Add stdp synapses to busyring.

af045e7

Add single CV

0c4a388

corrected config files for busyring STDP example

47cacdd

output of Arbor configuration

954aed9

config file adjustments

f92c010

checks and small adjustments

a5a3700

fixed counting of rings and synapses

929d038

example cases for Plastic Arbor paper

1c6347d

included missing header

70b84aa

jlubo force-pushed the test/busyring-stdp branch from 65a4a3a to 70b84aa Compare January 21, 2026 19:48

thorstenhater requested changes Jan 27, 2026

View reviewed changes

jlubo added 2 commits February 11, 2026 20:15

adapted 'synapses' parameter to count the random synapses only; code …

a39128a

…and documentation improvement

cleanup for config string method -- global version shall be introduce…

3d9a40c

…d in separate PR

jlubo requested a review from thorstenhater February 12, 2026 16:19

thorstenhater requested changes Feb 18, 2026

View reviewed changes

adjusted protocol of counting synapses (now again including the ring …

6be2364

…connection)

jlubo requested a review from thorstenhater April 8, 2026 16:33

thorstenhater approved these changes Apr 9, 2026

View reviewed changes

thorstenhater merged commit c053927 into arbor-sim:master Apr 9, 2026
27 of 28 checks passed

thorstenhater mentioned this pull request Apr 15, 2026

final clean-up before v0.12 #2504

Merged

thorstenhater mentioned this pull request Apr 16, 2026

Release v0.12 #2506

Merged

Conversation

jlubo commented Dec 23, 2025

Uh oh!

thorstenhater commented Jan 5, 2026

Uh oh!

jlubo commented Jan 21, 2026

Uh oh!

thorstenhater left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thorstenhater Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thorstenhater Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thorstenhater Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

jlubo Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

thorstenhater Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

thorstenhater left a comment

Choose a reason for hiding this comment

Uh oh!

jlubo commented Apr 8, 2026

Uh oh!

thorstenhater left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants