fix: testimonial section consistency across product pages#2584
fix: testimonial section consistency across product pages#2584AbhiVarde wants to merge 1 commit intoappwrite:mainfrom
Conversation
- Unify card spacing and height across all product testimonial sections - Replace inconsistent images on Functions page with correct ones - Add min-height constraint for consistent layout - Improve responsiveness on mobile - Ensure visual and structural consistency across all product pages Fixes appwrite#2583
WalkthroughThis pull request updates testimonial components across three Svelte files with consistent layout refinements. The changes replace fixed height constraints (h-fit) with minimum height containers (min-h-52) and adjust vertical content distribution from center-aligned to space-between alignment. Additionally, horizontal scrolling spacing is increased, card sizing becomes responsive with viewport-aware constraints, and image paths are updated in one component with specific contributor images. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@HarshMN2345 could you review this? Thanks! |
|
Thanks, @sara-k-48 ma’am! 🙂 |
HarshMN2345
left a comment
There was a problem hiding this comment.
Heyy @AbhiVarde , thanks for the contribution 👏🙌
I think the testimonials are intended to look like they did before, so we don’t need to enforce consistency here for now.
cc @ItzNotABug
|
Hey @HarshMN2345, totally understand! 🙏 Just to clarify, the goal wasn’t to enforce global consistency, but to fix a few UX issues I noticed:
If the original layout is intentional, I’m happy to adjust but these fixes came from a usability perspective. Maybe worth a quick check with design to confirm what they prefer 😊 |
What does this PR do?
Problem
Testimonials sections across product pages had multiple inconsistencies creating a fragmented user experience:
Functions Page:
k-collect.pngvsryan-oconner.png)w-lg)Auth, Storage & Sites Pages:
h-fitwithjustify-centerSolution
Standardized all testimonials components for unified design consistency across the website.
Changes Made
File:
src/routes/products/functions/(components)/Testimonials.svelteFile:
src/lib/components/product-pages/testimonials.svelteUpdated card height and layout
File:
src/lib/components/marketing/testimonials.svelteUpdated card height and layout
Test Plan
Before
After
Before (Mobile)
After (Mobile)
Related PRs and Issues
Fixes #2583
Have you read the Contributing Guidelines on issues?
Yes, I have read and followed the contributing guidelines.
Summary by CodeRabbit
Release Notes