Fix: issues in sites build settings #2770

HarshMN2345 · 2026-01-07T10:38:54Z

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

Release Notes

Bug Fixes
- Form fields now display helpful default prompts when adapter data is unavailable, improving setup guidance
- Enhanced error handling for static site configuration to prevent failures when adapter information is missing
Style
- Minor text formatting adjustment to upload instructions

_{✏️ Tip: You can customize this high-level summary in your review settings.}

appwrite · 2026-01-07T10:38:59Z

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Ready	View Logs	Preview URL

Tip

MCP server integration brings LLM superpowers to Claude Desktop and Cursor IDE

coderabbitai · 2026-01-07T10:39:13Z

Walkthrough

This pull request improves null/undefined handling across three site configuration and settings files. The changes introduce fallback placeholder text for form input fields when adapter data is unavailable, add optional chaining and default value logic for static adapter fallback file resolution, and remove a trailing semicolon from UI text. These modifications enhance the robustness of form inputs and adapter data access patterns without altering control flow or functional behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fix: issues in sites build settings' is vague and non-descriptive. It uses generic language ('issues') without specifying what problems were fixed or which specific improvements were made.	Consider using a more specific title that describes the actual changes, such as 'Add fallback placeholders for build commands and settings' or 'Improve error handling for adapter configuration in site settings.'

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte (1)
98-106: LGTM! Safe fallback logic for Static adapter.

The code correctly ensures a fallback value exists for Static adapters by using optional chaining and defaulting to 'index.html'. The logic safely handles cases where the Static adapter configuration might be missing.

Minor note: The inner if (!fallback) check is technically redundant since the ||= operator already performs this check, but the explicit condition improves readability and doesn't impact functionality.
♻️ Optional simplification

The inner if (!fallback) condition could be removed since ||= already checks if the left operand is falsy:
 $effect(() => {
     if (adapter === Adapter.Static) {
-        if (!fallback) {
-            fallback ||=
-                selectedFramework.adapters.find((a) => a.key === Adapter.Static)
-                    ?.fallbackFile || 'index.html';
-        }
+        fallback ||=
+            selectedFramework.adapters.find((a) => a.key === Adapter.Static)
+                ?.fallbackFile || 'index.html';
     }
 });
However, the current explicit structure is also acceptable and may be clearer to some readers.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63ebeaf and 209744e.

📒 Files selected for processing (3)

src/routes/(console)/project-[region]-[project]/sites/create-site/configuration.svelte
src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx,js,jsx,svelte}