fix: use unique names for chart series - #40
Open
yonasuriv wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR updates chart naming to preserve distinct series for model families containing multiple models and gives the cost-efficiency Y-axis more room for the resulting labels.
Confidence Score: 5/5The PR appears safe to merge, with the current model set producing unique chart identifiers and the wider axis accommodating the longer labels. The naming change removes existing family-level collisions across all current model inputs, while downstream chart keys and radar data identifiers receive distinct values. Important Files Changed
Reviews (1): Last reviewed commit: "fix: use unique names for chart series" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes duplicate React key warnings and a radar chart data-loss bug caused by
getShortName()collapsing every model in a family to a single name.key={entry.name}collided when a family had more than one model (Claude ×3, Gemini ×3, MiniMax ×2, Grok ×2), producing "two children with the same key" and dropping points in the radar chart.getShortName()now keeps the full model name for multi-model families ("Claude Opus 4.7" vs "Claude Fable 5") while leaving single-model families untouched.Also widens the CostEfficiency Y-axis so the longer labels fit.
Test plan
pnpm run checkandpnpm run buildpassresults-with-skills.jsonandresults-without-skills.jsonmap to unique chart names, no duplicates