Migrate docker image hosting from docker.pkg.github.com to ghcr.io#826
Open
Naishy wants to merge 1 commit into
Open
Migrate docker image hosting from docker.pkg.github.com to ghcr.io#826Naishy wants to merge 1 commit into
Naishy wants to merge 1 commit into
Conversation
docker.pkg.github.com is deprecated; also fixes the semver tag missing its v-prefix so it matches the tag action.yml actually pulls via github.action_ref, and updates the README's stale :main pull example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker.pkg.github.comtoghcr.io, using a simplified path (ghcr.io/appvia/githubusermanager).vprefix (v1.0.5instead of1.0.5) so it matches the tagaction.ymlactually requests viagithub.action_ref.docker run ...:mainexample toghcr.io/appvia/githubusermanager:latest(a tag that is actually produced by the workflow).Follow-up required (not part of this PR)
After this merges and the next push/release pushes an image to ghcr.io for the first time, an org admin needs to set the package visibility to public in GitHub package settings — ghcr.io defaults new packages to private, which would otherwise break external consumers pulling the action.
Test plan
ci.yml) runs successfully on this PR (build/lint/test steps; push step skipped for PRs)mainpushesghcr.io/appvia/githubusermanager:latestand:sha-*ghcr.io/appvia/githubusermanager:vX.Y.Zis pushed and matches what a consumer pinning@vX.Y.Zpulls