fix: cap Rating widget maxCount to 100 to prevent browser crash (#14833)#41897
Open
Piyush0049 wants to merge 2 commits into
Open
fix: cap Rating widget maxCount to 100 to prevent browser crash (#14833)#41897Piyush0049 wants to merge 2 commits into
Piyush0049 wants to merge 2 commits into
Conversation
…mithorg#14833) When a large number (e.g., 1000000) is provided as the max value for the Rating widget, the browser attempts to render millions of SVG star elements, causing an 'Aw, snap!' crash. Changes: - Added max: 100 to maxCount property validation to show an error in the property pane for values > 100 - Capped maxCount to 100 in getWidgetView() to safely handle data-binding edge cases where the bound value exceeds 100
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRateWidget now enforces a maximum count of 100: property-pane validation rejects values >100, and runtime rendering clamps the value with Math.min(this.props.maxCount || 5, 100) before passing it to RateComponent. ChangesRateWidget maxCount Capping
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/client/src/widgets/RateWidget/widget/index.tsx (1)
164-177:⚠️ Potential issue | 🟠 MajorCap
maxCountin RateWidget sizing to match the 100-star render cap
static getAutoLayoutConfig()/static getAnvilConfig()computeminWidthfrom the rawprops.maxCount, butgetWidgetView()clamps it viaconst safeMaxCount = Math.min(this.props.maxCount || 0, 100)before rendering. If a bound/runtimemaxCountexceeds 100, the widget can be laid out wider than what actually renders.Proposed fix
For
getAutoLayoutConfig():configuration: (props: RateWidgetProps) => { let maxCount = props.maxCount; if (typeof maxCount !== "number") // TODO: Fix this the next time the file is edited // eslint-disable-next-line `@typescript-eslint/no-explicit-any` maxCount = parseInt(props.maxCount as any, 10); + + // Cap maxCount to prevent excessive sizing + maxCount = Math.min(maxCount, 100); return { // 21 is the size of a star, 5 is the margin between stars minWidth: `${maxCount * 21 + (maxCount + 1) * 5}px`, minHeight: "40px", }; },For
getAnvilConfig():widgetSize: (props: RateWidgetProps) => { let maxCount = props.maxCount; if (typeof maxCount !== "number") // TODO: Fix this the next time the file is edited // eslint-disable-next-line `@typescript-eslint/no-explicit-any` maxCount = parseInt(props.maxCount as any, 10); + + // Cap maxCount to prevent excessive sizing + maxCount = Math.min(maxCount, 100); return { maxHeight: {}, maxWidth: {}, minHeight: { base: "40px" }, minWidth: { base: `${maxCount * 21 + (maxCount + 1) * 5}px` }, }; },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/client/src/widgets/RateWidget/widget/index.tsx` around lines 164 - 177, The layout config uses the raw props.maxCount to compute minWidth causing oversized layout when runtime maxCount > 100; in the configuration function used by static getAutoLayoutConfig() and static getAnvilConfig(), parse/normalize props.maxCount as you already do but then clamp it with const safeMaxCount = Math.min(Number(parsedMaxCount)||0, 100) (preserve the existing parseInt fallback behavior if needed) and use safeMaxCount in the minWidth/minHeight calculations instead of maxCount so sizing matches the 100-star render cap used by getWidgetView().
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/client/src/widgets/RateWidget/widget/index.tsx`:
- Line 478: Replace the current safeMaxCount calculation so it falls back to 5
instead of 0 and treats 0 as a valid value: change the assignment of
safeMaxCount to use nullish coalescing on this.props.maxCount and then clamp to
100, e.g. set safeMaxCount = Math.min(this.props.maxCount ?? 5, 100); this
preserves 0 as a valid input while using 5 when maxCount is null/undefined.
---
Outside diff comments:
In `@app/client/src/widgets/RateWidget/widget/index.tsx`:
- Around line 164-177: The layout config uses the raw props.maxCount to compute
minWidth causing oversized layout when runtime maxCount > 100; in the
configuration function used by static getAutoLayoutConfig() and static
getAnvilConfig(), parse/normalize props.maxCount as you already do but then
clamp it with const safeMaxCount = Math.min(Number(parsedMaxCount)||0, 100)
(preserve the existing parseInt fallback behavior if needed) and use
safeMaxCount in the minWidth/minHeight calculations instead of maxCount so
sizing matches the 100-star render cap used by getWidgetView().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 94edf28f-e58f-472a-9a62-e2010a58b711
📒 Files selected for processing (1)
app/client/src/widgets/RateWidget/widget/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a large number (e.g., 1000000) is provided as the max value for the Rating widget — either hardcoded or via data binding — the browser attempts to render millions of SVG star elements, causing an "Aw, snap!" crash with no way to recover.
Based on the requirements outlined by @dilippitchika in the issue comments:
max: 100to themaxCountvalidation params so the property pane shows an error for values greater than 100.maxCountto 100 ingetWidgetView()usingMath.min()to safely handle data-binding edge cases where the bound value exceeds 100.Fixes #14833
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit