fix(datasource): move expires_in field after scope in OAuth2 configuration form (#31059)

[derinbarutcu17]

Moves the 'Authorization expires in (seconds)' field to immediately after 'Scope(s)' in the OAuth2 Authorization Code form, so all authentication fields are grouped together. Pure UI reorder — no logic changes.

Before: scope → ... → custom auth params → expires_in
After: scope → expires_in → authorization URL → ...

Closes #31059

Summary by CodeRabbit

• Bug Fixes
  • Removed duplicate authentication expiration field and improved form field organization in REST API datasource configuration.

[coderabbitai]

Need an answer fast? Review this PR in Change Stack to ask focused questions about the PR or a changed range.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eecea0e5-fc63-4559-863a-34bc3afde463

📥 Commits

Reviewing files that changed from the base of the PR and between 293e1b6 and 86cf1f3.

📒 Files selected for processing (1)

• app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx

---

Walkthrough

The authentication.expiresIn field in the OAuth2 authorization code form is relocated to appear immediately after renderOauth2Common(), consolidating authentication-related inputs for improved field discovery. The previous duplicate rendering of this field is removed.

Changes

OAuth2 Authorization Form Field Reordering

Layer / File(s)	Summary
Reorder expires_in field in OAuth2 authorization code form app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx	The "Authorization expires in (seconds)" number input is moved to appear immediately after the OAuth common section within renderOauth2AuthorizationCode, consolidating related fields. The previous rendering location of this field is removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

📝 A field finds its home,
Grouped with its OAuth kin,
Expires_in flows smooth,
Where users see at first glance,
Order brings clarity. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: moving the expires_in field after scope in the OAuth2 configuration form, with issue reference.
Description check	✅ Passed	The description provides context, before/after ordering, and correctly references the linked issue. However, it lacks the standard template structure (Fixes issue format, Automation section, Communication checkbox).
Linked Issues check	✅ Passed	The PR successfully addresses issue #31059 by relocating the expires_in field immediately after scope in the OAuth2 form, matching the objective of grouping authentication fields together.
Out of Scope Changes check	✅ Passed	The changes are strictly scoped to reordering the expires_in field location as specified in issue #31059; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.