Abstract API: add declarative TLS request option to AHC and DefaultHTTPClient#168
Open
nakulbajaj wants to merge 2 commits into
Open
Abstract API: add declarative TLS request option to AHC and DefaultHTTPClient#168nakulbajaj wants to merge 2 commits into
nakulbajaj wants to merge 2 commits into
Conversation
nakulbajaj
requested review from
FranzBusch,
fabianfett,
guoye-zhang,
travarin and
xbhatnag
nakulbajaj
force-pushed
the
declarative-tls
branch
from
0f8ac96 to
c117bd8
Compare
guoye-zhang
reviewed
May 21, 2026
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| public import HTTPAPIs |
Collaborator
There was a problem hiding this comment.
These imports are not necessary since they were already reexported
guoye-zhang
reviewed
May 21, 2026
| @available(anyAppleOS 26.0, *) | ||
| extension HTTPClientCapability { | ||
| /// A protocol for HTTP request options that support TLS policies. | ||
| public protocol DeclarativeTLS: RequestOptions { |
Collaborator
There was a problem hiding this comment.
Probably want to discuss the naming a bit more
Member
There was a problem hiding this comment.
I agree both on the protocol name but also on the name of TrustEvaluationPolicy. We would normally call this ServerCertificateVerification
nakulbajaj
added
⚠️ semver/major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the declarative TLS request option to the abstract API and making sure AHC and thus DefaultHTTPClient support it for all platforms.
Longer term, we should also add an imperative option for cert validation.